Bug 1507362

Summary:	Review Request: python-pytest-tornado - Py.test plugin for testing of asynchronous tornado applications
Product:	[Fedora] Fedora	Reporter:	Elliott Sales de Andrade <quantum.analyst>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	eclipseo, package-review
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-11-11 03:13:50 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Elliott Sales de Andrade 2017-10-30 02:50:46 UTC

Spec URL: http://qulogic.fedorapeople.org//python-pytest-tornado.spec
SRPM URL: http://qulogic.fedorapeople.org//python-pytest-tornado-0.4.5-2.fc26.src.rpm

Description:
A py.test plugin providing fixtures and markers to simplify testing of
asynchronous tornado applications.

Comment 1 Elliott Sales de Andrade 2017-10-30 02:50:50 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=22795620

Comment 2 Robert-André Mauchin 🐧 2017-10-30 17:34:10 UTC

Hello,

 - Why do you grab a specific git commit instead of the release?

Source0:        https://github.com/eugeniy/%{srcname}/archive/v%{version}/%{srcname}-%{version}.tar.gz

   And

%autosetup -n %{srcname}-%{version}

   No need for commit0 and shortcommit0.


 - You need to own these two directories:

[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/python3.6/site-
     packages/pytest_tornado, /usr/lib/python2.7/site-
     packages/pytest_tornado

   Just remove the asterisks you added:

%files -n python2-%{srcname}
%license LICENSE
%doc README.rst
%{python2_sitelib}/pytest_tornado/
%{python2_sitelib}/pytest_tornado-%{version}-py?.?.egg-info


%files -n python3-%{srcname}
%license LICENSE
%doc README.rst
%{python3_sitelib}/pytest_tornado/
%{python3_sitelib}/pytest_tornado-%{version}-py?.?.egg-info

Comment 3 Elliott Sales de Andrade 2017-10-30 22:17:38 UTC

It was an old spec; I'm not sure the reason why the commit was used, but it seems to work with the regular version.

Spec URL: https://qulogic.fedorapeople.org/python-pytest-tornado.spec
SRPM URL: https://qulogic.fedorapeople.org/python-pytest-tornado-0.4.5-3.fc26.src.rpm

Comment 4 Robert-André Mauchin 🐧 2017-10-30 22:31:04 UTC

Package accepted.

Comment 5 Gwyn Ciesla 2017-11-06 22:16:23 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pytest-tornado

Comment 6 Fedora Update System 2017-11-06 23:37:23 UTC

python-pytest-tornado-0.4.5-3.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-85b70a29e4

Comment 7 Fedora Update System 2017-11-06 23:38:02 UTC

python-pytest-tornado-0.4.5-3.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0df8e93991

Comment 8 Fedora Update System 2017-11-07 19:14:36 UTC

python-pytest-tornado-0.4.5-3.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-85b70a29e4

Comment 9 Fedora Update System 2017-11-08 00:07:00 UTC

python-pytest-tornado-0.4.5-3.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-0df8e93991

Comment 10 Fedora Update System 2017-11-11 03:13:50 UTC

python-pytest-tornado-0.4.5-3.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2017-11-15 20:16:58 UTC

python-pytest-tornado-0.4.5-3.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.