Bug 1507657

Summary:	Review Request: nodejs-indexof - Lame indexOf thing
Product:	[Fedora] Fedora	Reporter:	MartinKG <mgansser>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	eclipseo, package-review
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-10-31 09:24:44 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1507662

Description MartinKG 2017-10-30 20:10:30 UTC

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nodejs-indexof.spec
SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/nodejs-indexof-0.0.1-1.fc26.src.rpm

Description: Lame indexOf thing
Fedora Account System Username: martinkg

%changelog
* Mon Oct 30 2017 Martin Gansser <martinkg> - 0.0.1-1
- First release

$ rpmlint -i -v nodejs-indexof.spec /home/martin/rpmbuild/SRPMS/nodejs-indexof-0.0.1-1.fc26.src.rpm /home/martin/rpmbuild/RPMS/noarch/nodejs-indexof-0.0.1-1.fc26.noarch.rpm
nodejs-indexof.spec: I: checking
nodejs-indexof.spec: I: checking-url http://registry.npmjs.org/indexof/-/indexof-0.0.1.tgz (timeout 10 seconds)
nodejs-indexof.src: I: checking
nodejs-indexof.src: I: checking-url https://www.npmjs.com/package/indexof (timeout 10 seconds)
nodejs-indexof.src: I: checking-url http://registry.npmjs.org/indexof/-/indexof-0.0.1.tgz (timeout 10 seconds)
nodejs-indexof.noarch: I: checking
nodejs-indexof.noarch: I: checking-url https://www.npmjs.com/package/indexof (timeout 10 seconds)
nodejs-indexof.noarch: W: only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.

2 packages and 1 specfiles checked; 0 errors, 1 warnings.

scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=22812845

Comment 1 Robert-André Mauchin 🐧 2017-10-30 20:37:41 UTC

All ok, package accepted.

Comment 2 MartinKG 2017-10-30 21:20:18 UTC

should i only create a package request for rawhide ? because the most nodejs-packages are only exist for rawhide.

Comment 3 Robert-André Mauchin 🐧 2017-10-30 21:52:58 UTC

I think so because your other dependencies are only available on Rawhide anyway.

Comment 4 Gwyn Ciesla 2017-10-31 01:23:48 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-indexof

Comment 5 MartinKG 2017-10-31 09:24:44 UTC

package has been built successfully on rawhide.