Bug 1507753

Summary:	Inconsistent environment variable action link text between config edit page and Environment tab
Product:	OpenShift Container Platform	Reporter:	XiaochuanWang <xiaocwan>
Component:	Management Console	Assignee:	Jakub Hadvig <jhadvig>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Yadan Pei <yapei>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3.7.0	CC:	aos-bugs, jhadvig, jokerman, mmccomas, spadgett, yapei
Target Milestone:	---
Target Release:	3.7.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-11-02 12:07:27 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description XiaochuanWang 2017-10-31 05:15:22 UTC

Description of problem:
Create an app, go to bc/dc edit page, check environment adding action link, go to Environment tab, compare the action link.

Version-Release number of selected component (if applicable):
Openshift v3.7.0-0.184.0

How reproducible:
Always

Steps to Reproduce:
1. Create an app by "Browse Catalog", choose i.e. Django + PostgreSQL (Persistent)
2. Go to bc/dc edit page, check the adding action links under "Environment Variables"
3. Go to bc/dc "Environment" tab, compare the text of action links

Actual results:
2. Two action links "Add Environment Variable | Add Environment Variable Using a Config Map or Secret"
3. Two action links are inconsistent "Add Value | Add Value from Config Map or Secret"

Expected results:
3. Tab page should be same as bc/dc edit page (3.6 is consistent, so the expected text is step2) 

Additional info:
Keep the same action name will take much good for web automation

Comment 1 Samuel Padgett 2017-10-31 12:07:09 UTC

> Tab page should be same as bc/dc edit page (3.6 is consistent, so the expected text is step2) 

We've purposely changed the wording based on feedback from UXS. We should use the new wording on other pages.

Comment 2 Jakub Hadvig 2017-10-31 12:44:30 UTC

PR: https://github.com/openshift/origin-web-console/pull/2404

Comment 3 openshift-github-bot 2017-10-31 13:31:49 UTC

Commits pushed to master at https://github.com/openshift/origin-web-console

https://github.com/openshift/origin-web-console/commit/00110d17782c3af1399f8ed61e690283f14ab5a0
Bug 1507753 - Make config page and environment tab actions consistent

https://github.com/openshift/origin-web-console/commit/2e5d6974c72a377f3e1d02aa96076a361f09b7d9
Merge pull request #2404 from jhadvig/bz1507753

Automatic merge from submit-queue.

Bug 1507753 - Make config page and environment tab actions consistent

When editing DC environment variables the action links are following: 
![current-env](https://user-images.githubusercontent.com/1668218/32218021-f1019e98-be29-11e7-87af-5ebe8f497740.png)

But the DC's Environment tab actions links are:
![old-env](https://user-images.githubusercontent.com/1668218/32218143-519da1b6-be2a-11e7-9a00-492aabc7c27d.png)

To be consistent (eg BC editor and BC Environment tab)  the action links wording in the DC env tab should be:
![new-env](https://user-images.githubusercontent.com/1668218/32218198-79e64952-be2a-11e7-8a8f-96fbd1993c26.png)
 
@spadgett PTAL

Comment 4 Samuel Padgett 2017-10-31 13:34:51 UTC

We've  changed other pages to use the new "Add Value | Add Value from Config Map or Secret" labels.

Note that we purposely did not change the BC editor "Add Environment Variable" since it doesn't support `valueFrom` and is a little different.

Comment 6 Yadan Pei 2017-11-02 08:44:57 UTC

Checked on v3.7.0-0.189.0


DC environment tab and config page now are "Add Value | Add Value from Config Map or Secret"

BC environment tab and config page keeps "Add Environment Variable" as intended.

Move to VERIFIED