Bug 1507815
Summary: | Handle twine as an application, not a library | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Nick Coghlan <ncoghlan> |
Component: | python-twine | Assignee: | Jeremy Cline <jeremy> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 26 | CC: | jcline, jeremy, randy |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2017-11-10 18:28:30 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Nick Coghlan
2017-10-31 08:49:03 UTC
Yeeeeah, this was one of my early packages and it's not very good. It seems to me it should probably just be called "twine", in addition to all the things you noted. I don't see anything specific in the guidelines, though. Thoughts? Yep, that would make sense - I had to make exactly the same change for fedmod [1] after realising the auto-generated spec from pyp2rpm was designed for Python libraries and frameworks, not command line tools that happened to be implemented in Python. However, it's a more annoying change to make, and the current SRPM name isn't actually *wrong* (since the python- prefix correctly implies that PyPI is twine's main upstream publication channel) So the changes definitely needed are: * RPM name -> twine (obsoleting both python2-twine and python3-twine) * no versioned binaries * builds for the default system Python only Whether or not to chang the SRPM name as well would be up to you - I'll note that one concrete advantage of the current name is that it makes it easier for automated tools to correlate the system package with the upstream project. [1] https://pagure.io/modularity/fedmod/issue/27 I opted to leave the SRPM name the same, but the RPM is now just "twine". Fixed in python-twine-1.9.1-3.fc28 Thank you! |