Bug 150798
| Summary: | useless patch in iproute2 src rpm | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Stephen Hemminger <shemminger> |
| Component: | iproute | Assignee: | Radek Vokál <rvokal> |
| Status: | CLOSED RAWHIDE | QA Contact: | Brock Organ <borgan> |
| Severity: | low | Docs Contact: | |
| Priority: | medium | ||
| Version: | 3 | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2005-05-24 09:51:04 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
you're right, this looks really useless. I'm making a note down and it will get removed in next release .. removed it's still in cvs, just not applied via spec file ... |
Why are you including the bogus patch iproute-2.4.7-initvar.patch? It adds extra assign to zero when the structure has just been memset to zero? *Duh* it's already zero. ----------- --- iproute2/ip/iproute.c.initvar 2004-04-21 16:57:59.307562694 +0200 +++ iproute2/ip/iproute.c 2004-04-21 16:58:35.353103364 +0200 @@ -620,6 +620,9 @@ } memset(rtnh, 0, sizeof(*rtnh)); rtnh->rtnh_len = sizeof(*rtnh); + rtnh->rtnh_ifindex = 0; + rtnh->rtnh_flags = 0; + rtnh->rtnh_hops = 0; rta->rta_len += rtnh->rtnh_len; parse_one_nh(rta, rtnh, &argc, &argv); rtnh = RTNH_NEXT(rtnh);