Bug 1507997
| Summary: | Review Request: gnome-video-arcade - simple MAME front-end | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matthew Barnes <mbarnes> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | eclipseo, package-review |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | eclipseo:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-11-15 17:57:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Matthew Barnes
2017-10-31 16:20:29 UTC
Hello, - Group: is not used in Fedora. See: https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections - make %{?_smp_mflags} → %make_build - make install DESTDIR=$RPM_BUILD_ROOT → %make_install - glib-compile-schemas is not needed in %postun and %posttrans for Fedora >= 24. See: https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets&oldid=481889#GSettings_Schema - There should not be any %defattr(-,root,root,-) in %files - The COPYING file should be included with the %license macro, not %doc: %doc AUTHORS ChangeLog NEWS README %license COPYING - Use pkgconfig for BR when you can: BuildRequires: desktop-file-utils BuildRequires: gettext BuildRequires: pkgconfig(gsettings-desktop-schemas) BuildRequires: pkgconfig(gtk+-3.0) >= %{gtk3_version} BuildRequires: intltool BuildRequires: pkgconfig(x11) BuildRequires: pkgconfig(libsoup-2.4) BuildRequires: pkgconfig(libwnck-3.0) >= %{libwnck3_version} BuildRequires: perl-XML-Parser BuildRequires: pkgconfig(sqlite3) BuildRequires: yelp-tools - Consider adding an Appdata file: https://fedoraproject.org/wiki/Packaging:AppData Thanks for looking at this so quickly. Being as I'm the upstream author, I'll defer on the Appdata file for now and add it upstream for the next release, if that's acceptable to you. Uploaded new spec/srpms that I believe addressed everything else. You've added a typo: BuildRequires: pkgconfig(libsoup2.4) ⇒ BuildRequires: pkgconfig(libsoup-2.4) Package otherwise accepted, just don't forget to fix the typo before import. Thanks, good catch! (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gnome-video-arcade Packages built for rawhide, f26, and f27. gnome-video-arcade-0.8.8-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-1054855589 gnome-video-arcade-0.8.8-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-89e42e75cb gnome-video-arcade-0.8.8-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-89e42e75cb gnome-video-arcade-0.8.8-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-1054855589 gnome-video-arcade-0.8.8-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. gnome-video-arcade-0.8.8-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. |