Bug 1508085

Summary: Enable the service catalog, template broker and ansible service broker by default
Product: OpenShift Container Platform Reporter: Fabian von Feilitzsch <fabian>
Component: InstallerAssignee: Scott Dodson <sdodson>
Status: CLOSED ERRATA QA Contact: Johnny Liu <jialiu>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 3.7.0CC: aos-bugs, jokerman, mmccomas, wmeng, xtian
Target Milestone: ---   
Target Release: 3.7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
OCP 3.7 now enables the service catalog, ansible service broker, and template service broker by default.
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-11-28 22:20:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Fabian von Feilitzsch 2017-10-31 19:51:08 UTC
Description of problem:
Currently you need to set the ansible_service_broker_install flag to true in order for the broker to deploy (it defaults to false). Instead, we should default to installing the broker when the catalog is installed.

Steps to Reproduce:
1. Set the catalog to install
2. Run the installer

Actual results:
The catalog is installed but not the broker

Expected results:
the broker and catalog should both be installed

Comment 1 Fabian von Feilitzsch 2017-10-31 19:53:36 UTC
https://github.com/openshift/openshift-ansible/pull/5958

Comment 2 Fabian von Feilitzsch 2017-10-31 19:57:53 UTC
https://github.com/openshift/openshift-ansible/pull/5959/files

Comment 3 Fabian von Feilitzsch 2017-10-31 20:06:39 UTC
Updated Description of problem:
Currently you need to set the openshift_enable_service_catalog, ansible_service_broker_install, and template_service_broker flags to true in order for the catalog and both broker to install. They should all install by default.

Steps to Reproduce:
1. Don't set any of the broker/catalog flags
2. Run the installer

Actual results:
The catalog and brokers are not installed

Expected results:
the brokers and catalog should be installed

Comment 6 Johnny Liu 2017-11-06 08:04:59 UTC
Re-test this bug with openshift-ansible-3.7.0-0.195.0.git.0.5efcf4a.el7.noarch, FAIL.


Don't set any of service catalog/ASB/TSB flags, trigger installation, found only service catalog role are called, no ASB/TSB role is called.


TASK [ansible_service_broker : Set default image variables based on deployment type] ***
Monday 06 November 2017  07:10:17 +0000 (0:00:00.031)       0:23:33.661 ******* 
skipping: [ec2-34-207-172-11.compute-1.amazonaws.com] => (item=/home/slave4/workspace/Launch Environment Flexy/private-openshift-ansible/roles/ansible_service_broker/vars/openshift-enterprise.yml)  => {"changed": false, "item": "/home/slave4/workspace/Launch Environment Flexy/private-openshift-ansible/roles/ansible_service_broker/vars/openshift-enterprise.yml", "skip_reason": "Conditional result was False", "skipped": true}
<--snip-->
TASK [template_service_broker : Set default image variables based on deployment type] ***
Monday 06 November 2017  07:10:19 +0000 (0:00:00.030)       0:23:34.960 ******* 
skipping: [ec2-34-207-172-11.compute-1.amazonaws.com] => (item=/home/slave4/workspace/Launch Environment Flexy/private-openshift-ansible/roles/template_service_broker/vars/openshift-enterprise.yml)  => {"changed": false, "item": "/home/slave4/workspace/Launch Environment Flexy/private-openshift-ansible/roles/template_service_broker/vars/openshift-enterprise.yml", "skip_reason": "Conditional result was False", "skipped": true}


I guess that is because the following default value is not changed.

roles/ansible_service_broker/defaults/main.yml:ansible_service_broker_install: false
roles/template_service_broker/defaults/main.yml:template_service_broker_install: False

Comment 7 Scott Dodson 2017-11-06 14:47:57 UTC
https://github.com/openshift/openshift-ansible/pull/6020 additional fixes

Comment 9 Weihua Meng 2017-11-09 03:36:43 UTC
Fixed in openshift-ansible-3.7.4-1.git.0.254e849.el7.noarch.rpm

service catalog, template broker and ansible service broker are enabled by default

Comment 12 errata-xmlrpc 2017-11-28 22:20:57 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:3188