Bug 1508278

Summary: [APB] Need to use up-to-date feature rather than the one will be removed
Product: OpenShift Container Platform Reporter: Weihua Meng <wmeng>
Component: Service BrokerAssignee: cchase
Status: CLOSED ERRATA QA Contact: Weihua Meng <wmeng>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.7.0CC: aos-bugs, jmatthew, jmontleo, xtian
Target Milestone: ---   
Target Release: 3.7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
undefined
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-11-28 22:20:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1508724, 1509246    
Bug Blocks:    

Description Weihua Meng 2017-11-01 03:31:02 UTC
Description of problem:
Need to use up-to-date feature rather than the one will be removed

Version-Release number of selected component (if applicable):
# docker images
REPOSITORY                                                                                   TAG                 IMAGE ID            CREATED             SIZE
docker.io/ansibleplaybookbundle/rhscl-postgresql-apb                                         latest              ae2cca5553a9        26 hours ago        671.2 MB
docker.io/ansibleplaybookbundle/rhscl-postgresql-apb                                         sprint139.1         ae2cca5553a9        26 hours ago        671.2 MB

How reproducible:
Always

Steps to Reproduce:
1. provision postgresql-apb
2. check apb pod logs
# oc logs -n dh-rhscl-postgresql-apb-prov-qts4q po/apb-8c276ef0-152c-4cba-a54d-4929396c2a5f

Actual results:
There are warnings:

+ ansible-playbook /opt/apb/actions/provision.yaml --extra-vars '{"_apb_plan_id":"prod","namespace":"wmeng5","postgresql_database":"wmeng5"}' --extra-vars no_log=true --extra-vars @/tmp/secrets
 [WARNING]: Could not match supplied host pattern, ignoring: all
 [WARNING]: provided hosts list is empty, only localhost is available
[DEPRECATION WARNING]: The use of 'include' for tasks has been deprecated. Use 
'import_tasks' for static inclusions or 'include_tasks' for dynamic inclusions.
 This feature will be removed in a future release. Deprecation warnings can be 
disabled by setting deprecation_warnings=False in ansible.cfg.
[DEPRECATION WARNING]: include is kept for backwards compatibility but usage is
 discouraged. The module documentation details page may explain more about this
 rationale.. This feature will be removed in a future release. Deprecation 
warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
 [WARNING]: Found variable using reserved name: no_log
PLAY [Deploy rhscl-postgresql-apb to openshift] ********************************

Expected results:
These warnings need to be addressed, otherwise, we will get error in future as it said.
No warnings are expected.

Additional info:

Comment 1 cchase 2017-11-02 14:25:42 UTC
This looks to be an issue in rhscl-postgresql-apb, rhscl-mysql-apb, and rhscl-mariadb-apb.  I've put in fixes for all 3 to use include_tasks.

https://github.com/ansibleplaybookbundle/rhscl-postgresql-apb/pull/12
https://github.com/ansibleplaybookbundle/rhscl-mysql-apb/pull/8
https://github.com/ansibleplaybookbundle/rhscl-mariadb-apb/pull/6

Comment 3 Jason Montleon 2017-11-07 13:57:57 UTC
Should be fixed in:
mariadb-apb-role-1.0.7-1
mysql-apb-role-1.0.9-1
postgresql-apb-role-1.0.13-1

These should show up in a release or two after v3.7.0-0.197.0.0 iamges.

Comment 4 Weihua Meng 2017-11-09 06:23:08 UTC
Fixed in latest images.
No [WARNING] found.

openshift3/mediawiki-apb:v3.7.0-0.198.0.3
openshift3/mariadb-apb:v3.7.0-0.198.0.3
openshift3/mysql-apb:v3.7.0-0.198.0.3
openshift3/postgresql-apb:v3.7.0-0.198.0.3

Comment 7 errata-xmlrpc 2017-11-28 22:20:57 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:3188