Bug 1508352

Summary:	[CRI-O] default log-level should avoid use debug in product
Product:	OpenShift Container Platform	Reporter:	DeShuai Ma <dma>
Component:	Containers	Assignee:	Giuseppe Scrivano <gscrivan>
Status:	CLOSED ERRATA	QA Contact:	DeShuai Ma <dma>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3.7.0	CC:	amurdaca, aos-bugs, decarr, jokerman, mmccomas, mpatel
Target Milestone:	---
Target Release:	3.8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:	undefined	Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-03-28 14:08:55 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description DeShuai Ma 2017-11-01 09:50:13 UTC

Description of problem:
Now in cri-o system container the log-level=debug, In product we should avoid use debug mode.

Version-Release number of selected component (if applicable):
crio version 1.0.2
commit: "29077fa6fbd85f0ca9c453ab1bf1ff7b02bc3f5c"

How reproducible:
Always

Steps to Reproduce:
1.Get cri-o from private registry then check the loglevel
[root@ip-172-18-4-251 cri-o.0]# pwd
/var/lib/containers/atomic/cri-o.0
[root@ip-172-18-4-251 cri-o.0]# cat rootfs/usr/bin/run.sh
#!/bin/sh

# Ensure that new process maintain this SELinux label
PID=$$
LABEL=`tr -d '\000' < /proc/$PID/attr/current`
printf %s $LABEL > /proc/self/attr/exec

exec /usr/bin/crio --log-level=debug

2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Derek Carr 2017-11-01 15:42:06 UTC

cri-o related bugs are not blocking 3.7, all cri-o bugs should default target release of 3.8.

Comment 2 Mrunal Patel 2017-11-03 17:23:00 UTC

Giuseppe,
Can we fix this in the installer config?

Comment 3 Giuseppe Scrivano 2017-11-03 19:20:31 UTC

PR here: https://github.com/projectatomic/atomic-system-containers/pull/139

Comment 4 Antonio Murdaca 2017-11-03 20:04:10 UTC

PR merged, moved to MODIFIED

Comment 6 DeShuai Ma 2018-01-04 08:42:10 UTC

Verify on crio version 1.8.2
# cd /var/lib/containers/atomic/cri-o.0
# ./rootfs/usr/bin/crio --version
crio version 1.8.2

# cat rootfs/usr/bin/run.sh
#!/bin/sh

# Ensure that new process maintain this SELinux label
PID=$$
LABEL=`tr -d '\000' < /proc/$PID/attr/current`
printf %s $LABEL > /proc/self/attr/exec

exec /usr/bin/crio --log-level=$LOG_LEVEL
# cat config.json |grep "LOG_LEVEL"
      "LOG_LEVEL=info",

Comment 9 errata-xmlrpc 2018-03-28 14:08:55 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0489