Bug 1508601

Summary: Add NetIpMap to hieradata for *ExtraConfig overrides (Composable Networks)
Product: Red Hat OpenStack Reporter: Alexander Chuzhoy <sasha>
Component: openstack-tripleo-heat-templatesAssignee: Steven Hardy <shardy>
Status: CLOSED ERRATA QA Contact: Alexander Chuzhoy <sasha>
Severity: medium Docs Contact:
Priority: medium    
Version: 12.0 (Pike)CC: bfournie, emacchi, jcoufal, jstransk, mburns, mlammon, rhel-osp-director-maint
Target Milestone: z2Keywords: Triaged, ZStream
Target Release: 12.0 (Pike)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-tripleo-heat-templates-7.0.9-1.el7ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-03-28 17:14:53 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Alexander Chuzhoy 2017-11-01 18:44:01 UTC
To enable per-node override of bind IPs via the per-role ExtraConfig paramaters, we need to enable hiera interpolation that references the keys defined in NetIpMap, so we add them to the hieradata. 
To minimise the risk of any conflicts in keynames it's added near the bottom of the hierarchy, but I'm not aware of any conflicting names in our templates/modules.
This will allow per-node hieradata override of bind IPs e.g: 
parameter_defaults: 
  ComputeRack1ExtraConfig: nova::vncproxy::host: "%{hiera('rack1_internal_api')}"
  ComputeRack2ExtraConfig: nova::vncproxy::host: "%{hiera('rack2_internal_api')}

Comment 1 Jiri Stransky 2017-11-03 15:24:15 UTC
Merged in stable/pike.

Comment 7 mlammon 2018-03-14 22:00:53 UTC
Deploy latest osp 12 2018-03-10.1

Env
openstack-tripleo-heat-templates-7.0.9-6.el7ost.noarch

To verify:

[root@undercloud-0 ~]# cat /usr/share/openstack-tripleo-heat-templates/puppet/role.role.j2.yaml | grep net_ip_map
          - net_ip_map
          net_ip_map: {get_attr: [NetIpMap, net_ip_map]}
              - values: {get_attr: [NetIpMap, net_ip_map]}
          PRIMARYIP: {get_attr: [NetIpMap, net_ip_map, {get_param: [ServiceNetMap, {{role.name}}HostnameResolveNetwork]}]}
          PRIMARYIP: {get_attr: [NetIpMap, net_ip_map, {get_param: [ServiceNetMap, {{role.name}}HostnameResolveNetwork]}]}

Look on controller -

[heat-admin@controller-0 ~]$ sudo cat /etc/puppet/hieradata/net_ip_map.json
{
    "ctlplane": "192.168.24.18",
    "ctlplane_subnet": "192.168.24.18/24",
    "ctlplane_uri": "192.168.24.18",
    "external": "10.0.0.107",
    "external_subnet": "10.0.0.107/24",
    "external_uri": "10.0.0.107",
    "internal_api": "172.17.1.20",
    "internal_api_subnet": "172.17.1.20/24",
    "internal_api_uri": "172.17.1.20",
    "management": "192.168.24.18",
    "management_subnet": "192.168.24.18/24",
    "management_uri": "192.168.24.18",
    "storage": "172.17.3.14",
    "storage_mgmt": "172.17.4.12",
    "storage_mgmt_subnet": "172.17.4.12/24",
    "storage_mgmt_uri": "172.17.4.12",
    "storage_subnet": "172.17.3.14/24",
    "storage_uri": "172.17.3.14",
    "tenant": "172.17.2.15",
    "tenant_subnet": "172.17.2.15/24",
    "tenant_uri": "172.17.2.15"

Comment 10 errata-xmlrpc 2018-03-28 17:14:53 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:0602