Bug 1508898

Summary:	Add new configuration option to manage deletion of Worm files
Product:	[Community] GlusterFS	Reporter:	Vishal Pandey <vpandey>
Component:	unclassified	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.13	CC:	bugs, ksubrahm
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-4.0.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-12-08 17:45:00 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Vishal Pandey 2017-11-02 13:13:51 UTC

Description of problem: Add a new configuration option to file level Worm in order to control deletion of Worm Files.


Version-Release number of selected component (if applicable):

Steps to Test:
1. Add all the configuration options to a volume to activate file-level-worm
2. Add an additional config option features.worm-files-deletable 1
3. Stop and start the volume for the changes to take effect.
4. Create a new file and wait for the retention time to expire.
5. After retention time expires, do `rm -f filename` for state transition to Worm    State.
6. The file is successfully removed.
7. Repeat from step 2by setting features.worm-files-deletable 1. This time deletion should not be successful. 

Expected results:
1. When worm-files-deletable is set as 1, files in Worm state can be deleted.
2. When worm-files-deletable is set as 0, files in Worm state can't be deleted.

Comment 1 Worker Ant 2017-11-02 13:57:37 UTC

REVIEW: https://review.gluster.org/18633 (write once read many: new config option to manage deletion of Worm files.) posted (#1) for review on master by Vishal Pandey

Comment 2 Worker Ant 2017-11-20 11:42:18 UTC

COMMIT: https://review.gluster.org/18633 committed in master by \"Vishal Pandey\" <vpandey> with a commit message- features/worm: new config option to manage deletion of Worm files.

Add a new configuration option worm-files-deletable to
 file-level Worm in order to control behaviour of Worm files upon deletion.

Steps to Test:
1. Add all the configuration options to a volume to activate file-level-worm
2. Option features.worm-files-deletable is set to 1 by default.
3. Create a new file and wait for the retention time to expire.
4. After retention time expires, do an truncate, rename, unlink, link
   or write to send the file in Worm state.
5. After that do `rm -f filename`.
6. The file is successfully removed.
7. Repeat from step 2 by setting features.worm-files-deletable 0.
   This time deletion should not be successful.

Change-Id: Ibc89861ee296e065330b93a9f9606be5da40af31
BUG: 1508898
Signed-off-by: Vishal Pandey <vishpandey2014>

Comment 3 Worker Ant 2017-11-21 13:52:47 UTC

REVIEW: https://review.gluster.org/18833 (features/worm: new config option to manage deletion of Worm files.) posted (#1) for review on release-3.13 by Vishal Pandey

Comment 4 Worker Ant 2017-11-22 13:48:39 UTC

COMMIT: https://review.gluster.org/18833 committed in release-3.13 by \"Vishal Pandey\" <vpandey> with a commit message- features/worm: new config option to manage deletion of Worm files.

Add a new configuration option worm-files-deletable to
 file-level Worm in order to control behaviour of Worm files upon deletion.

Steps to Test:
1. Add all the configuration options to a volume to activate file-level-worm
2. Option features.worm-files-deletable is set to 1 by default.
3. Create a new file and wait for the retention time to expire.
4. After retention time expires, do an truncate, rename, unlink, link
   or write to send the file in Worm state.
5. After that do `rm -f filename`.
6. The file is successfully removed.
7. Repeat from step 2 by setting features.worm-files-deletable 0.
   This time deletion should not be successful.

Change-Id: Ibc89861ee296e065330b93a9f9606be5da40af31
BUG: 1508898
Signed-off-by: Vishal Pandey <vishpandey2014>

Comment 5 Shyamsundar 2017-12-08 17:45:00 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.13.0, please open a new bug report.

glusterfs-3.13.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-December/000087.html
[2] https://www.gluster.org/pipermail/gluster-users/

Comment 6 Shyamsundar 2018-03-15 11:19:42 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-4.0.0, please open a new bug report.

glusterfs-4.0.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2018-March/000092.html
[2] https://www.gluster.org/pipermail/gluster-users/