Bug 1509086
| Summary: | Many GNOME crashes erroneously marked as dupes of 1469813, 1510059... due to glib 'log and then crash' codepaths (_g_log_abort) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adam Williamson <awilliam> |
| Component: | satyr | Assignee: | Matej Habrnal <mhabrnal> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | high | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 27 | CC: | abrt-devel-list, alexvillacislasso, fedora, jakub, jan.public, jmilan, kevin, mhabrnal, michal.toman, mkutlak, mmarusak, msuchy |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | satyr-0.24-2.fc28 satyr-0.25-1.fc27 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-01-30 18:07:28 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Adam Williamson
2017-11-02 23:16:04 UTC
This pull request should fix the issue: https://github.com/abrt/satyr/pull/264 *** Bug 1526166 has been marked as a duplicate of this bug. *** Can we please get this change pushed out as an update for F26 and F27? I see the change has gone to Rawhide in a -2 package build, but it has not gone to F26 or F27 so far as I can see, and of course the majority of Fedora users are on stable releases, not Rawhide. So we are still seeing problems caused by this. The most recent one we came across is https://bugzilla.redhat.com/show_bug.cgi?id=1510059 - once again, many unrelated bugs are being closed as dupes of that (or the reporters are just getting comments added on that bug, instead of new bugs filed) due to this _g_log_abort issue. 1510059 also shows a slightly different path to _g_log_abort, perhaps one or more of these functions should also be added to this 'blacklist': #0 raise at ../sysdeps/unix/sysv/linux/raise.c:51 #1 dump_gjs_stack_on_signal_handler at ../src/main.c:372 #3 _g_log_abort at gmessages.c:554 #4 g_log_writer_default at gmessages.c:2628 #5 g_log_structured_array at gmessages.c:1941 #6 g_log_structured at gmessages.c:1768 note we get in via g_log_structured -> g_log_structured_array -> g_log_writer_default , not default_log_handler -> g_log_default_handler like all the other cases. For the record, I found a few other bugs like this, and unpicked all those dupes too. The biggest were: https://bugzilla.redhat.com/show_bug.cgi?id=1370073 (F25) https://bugzilla.redhat.com/show_bug.cgi?id=1402492 (F26) It's also worth noting that one fairly common case is that GNOME crashes on this codepath with the critical error message just being "Connection to xwayland lost." All that tells us, really, is that XWayland crashed; it doesn't tell us why, nor does it mean at all that all bugs which hit that codepath are dupes of each other. I'm not sure if it's possible for abrt to handle that well, but it'd be great if it could. I've created pull request which adds g_log_structured -> g_log_structured_array -> g_log_writer_default functions into "blacklist". https://github.com/abrt/satyr/pull/270 Will backport all added "blacklisted" functions to f27 and f26. Thanks a lot! satyr-0.25-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-580c89505f satyr-0.25-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-580c89505f satyr-0.25-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. |