Bug 1509151

Summary:	Improve the error message when improper number set for vcpu current number
Product:	Red Hat Enterprise Linux 7	Reporter:	yalzhang <yalzhang>
Component:	libvirt	Assignee:	Peter Krempa <pkrempa>
Status:	CLOSED ERRATA	QA Contact:	yalzhang <yalzhang>
Severity:	unspecified	Docs Contact:
Priority:	medium
Version:	7.5	CC:	lhuang, mtessun, rbalakri, xuzhang
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libvirt-3.9.0-2.el7	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-04-10 10:59:09 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description yalzhang@redhat.com 2017-11-03 08:06:43 UTC

Description of problem:
Suggest to improve the error message when set improper vcpu current number using virsh edit.

Version-Release number of selected component (if applicable):
libvirt-3.9.0-1.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. modify the vcpu current number more than the max vcpu number.

# virsh edit rhel7
...
<vcpu placement='static' current='9'>8</vcpu>
...

error: unsupported configuration: maxvcpus must not be less than current vcpus (9 < 8)
Failed. Try again? [y,n,i,f,?]: 


Actual results:
looks like the two numbers are reversed. Also they don't make much sense in the format they are in. The message should be changed.

Expected results:
How about
"error: unsupported configuration: current vcpus must be less than maxvcpus
Failed. Try again? [y,n,i,f,?]: "

Additional info:

Comment 2 Peter Krempa 2017-11-13 12:47:03 UTC

Fixed upstream:

commit 50712e14f40ffdac8a71ce9ef091e4e7bd822585
Author: Peter Krempa <pkrempa>
Date:   Fri Nov 3 09:31:30 2017 +0100

    conf: Fix message when maximum vCPU count is less than current
    
    Reword the message and drop the numbers (which were reversed) from it
    so that it actually makes sense.

Comment 5 yalzhang@redhat.com 2017-11-16 03:29:50 UTC

Test on libvirt-3.9.0-2.el7.x86_64, the error message is sensible, verify this bug

# virsh edit rhel
error: unsupported configuration: maximum vCPU count must not be less than current vCPU count
Failed. Try again? [y,n,i,f,?]: ==> press 'i'
error: unsupported configuration: maximum vCPU count must not be less than current vCPU count
Failed. Try again? [y,n,f,?]:  ==> press 'f'
error: unsupported configuration: maximum vCPU count must not be less than current vCPU count
Failed. Try again? [y,n,f,?]:

Comment 9 errata-xmlrpc 2018-04-10 10:59:09 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:0704