Bug 150920

Summary: buildinstall won't forward --debug to second stage
Product: [Fedora] Fedora Reporter: Ingo Pakleppa <ingo-rhbugzilla>
Component: anacondaAssignee: Anaconda Maintenance Team <anaconda-maint-list>
Status: CLOSED RAWHIDE QA Contact: Mike McLean <mikem>
Severity: medium Docs Contact:
Priority: medium    
Version: 2   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-03-14 18:37:35 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ingo Pakleppa 2005-03-12 00:21:00 UTC
Description of problem:

The /usr/lib/anaconda-runtime/buildinstall script will not forward the
--debug argument to the second stage.

Version-Release number of selected component (if applicable):

10.0.2, but the same problem also seems to exist in the 10.1 series.

How reproducible:

Run the buildinstall script with the --debug argument. Note that the
upd-instroot script will not print any debug information.

Steps to Reproduce:
1.
2.
3.
  
Actual results:
upd-instroot only prints "Expanding text packages" and then "Expanding
graphical packages"

Expected results:
upd-instroot will show which packages are being extracted right now.

Side note: there is a second bug in upd-instroot in that "Expanding
graphical packages" is printed *after* instead of before expanding.

Additional info:

Here is a patch to fix this issue. Patched against 10.0.2.

diff -Naurb anaconda-10.0.2.original/scripts/buildinstall
anaconda-10.0.2/scripts/buildinstall
--- anaconda-10.0.2.original/scripts/buildinstall       2004-03-16
14:18:49.000000000 -0800
+++ anaconda-10.0.2/scripts/buildinstall        2005-03-10
14:19:19.000000000 -0800
@@ -128,9 +128,9 @@
 echo "Going to run buildinstall again"
 # run it again for the second half
 if [ -x /usr/bin/runroot ]; then
-    runroot $COMPNAME --onlyone --arch $BUILDARCH "$BUILDINSTALL
--buildinstdir $BUILDINSTDIR --second $PKGORDERSTR --comp $COMPNAME
--version $VERSION --release '\"$RELEASESTR\"' --product
'\"$PRODUCTSTR\"' --prodpath $PRODUCTPATH --discs '\"$DISCSTR\"' $DIR"
+    runroot $COMPNAME --onlyone --arch $BUILDARCH "$BUILDINSTALL
$DEBUGSTR --buildinstdir $BUILDINSTDIR --second $PKGORDERSTR --comp
$COMPNAME --version $VERSION --release '\"$RELEASESTR\"' --product
'\"$PRODUCTSTR\"' --prodpath $PRODUCTPATH --discs '\"$DISCSTR\"' $DIR"
 else
-    $BUILDINSTALL --buildinstdir $BUILDINSTDIR --second $PKGORDERSTR
--comp $COMPNAME --version $VERSION --release "$RELEASESTR" --product
"$PRODUCTSTR" --prodpath $PRODUCTPATH --discs "$DISCSTR" $DIR
+    $BUILDINSTALL $DEBUGSTR --buildinstdir $BUILDINSTDIR --second
$PKGORDERSTR --comp $COMPNAME --version $VERSION --release
"$RELEASESTR" --product "$PRODUCTSTR" --prodpath $PRODUCTPATH --discs
"$DISCSTR" $DIR
 fi

 rm -rf $BUILDINSTDIR

Comment 1 Jeremy Katz 2005-03-14 18:37:35 UTC
Thanks for the patch.  Applied in CVS.