Bug 1509324

Summary: default openstack overcloud container image prepare returns entries for RDO containers
Product: Red Hat OpenStack Reporter: Jon Schlueter <jschluet>
Component: openstack-tripleo-commonAssignee: Martin André <m.andre>
Status: CLOSED ERRATA QA Contact: Omri Hochman <ohochman>
Severity: urgent Docs Contact:
Priority: high    
Version: 12.0 (Pike)CC: dbecker, jcoufal, m.andre, mburns, mcornea, morazi, rhel-osp-director-maint, slinaber
Target Milestone: rcKeywords: Triaged
Target Release: 12.0 (Pike)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-tripleo-common-7.6.3-2.el7ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-12-13 22:19:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jon Schlueter 2017-11-03 14:33:38 UTC
Description of problem:

OSP 12 overcloud container image prepare does not return container_images.yaml file that would pull OSP 12 targeted containers.

Version-Release number of selected component (if applicable):

Beta Candidate Puddle (2017-11-02.3 puddle)

How reproducible:

Always

Steps to Reproduce:
1. install undercloud
2. openstack overcloud container image prepare


Actual results:
[stack@undercloud-0 ~]$ openstack overcloud container image prepare                                                                                                                                                                           
container_images:
- imagename: tripleoupstream/centos-binary-aodh-api:latest
- imagename: tripleoupstream/centos-binary-aodh-evaluator:latest
- imagename: tripleoupstream/centos-binary-aodh-listener:latest
- imagename: tripleoupstream/centos-binary-aodh-notifier:latest
- imagename: tripleoupstream/centos-binary-ceilometer-central:latest
- imagename: tripleoupstream/centos-binary-ceilometer-compute:latest
- imagename: tripleoupstream/centos-binary-ceilometer-notification:latest
- imagename: tripleoupstream/centos-binary-cron:latest
- imagename: tripleoupstream/centos-binary-glance-api:latest
- imagename: tripleoupstream/centos-binary-gnocchi-api:latest
- imagename: tripleoupstream/centos-binary-gnocchi-metricd:latest
- imagename: tripleoupstream/centos-binary-gnocchi-statsd:latest
- imagename: tripleoupstream/centos-binary-haproxy:latest
- imagename: tripleoupstream/centos-binary-heat-api-cfn:latest
- imagename: tripleoupstream/centos-binary-heat-api:latest
- imagename: tripleoupstream/centos-binary-heat-engine:latest
- imagename: tripleoupstream/centos-binary-horizon:latest
- imagename: tripleoupstream/centos-binary-keystone:latest
- imagename: tripleoupstream/centos-binary-mariadb:latest
- imagename: tripleoupstream/centos-binary-memcached:latest
- imagename: tripleoupstream/centos-binary-nova-api:latest
- imagename: tripleoupstream/centos-binary-nova-compute:latest
- imagename: tripleoupstream/centos-binary-nova-conductor:latest
- imagename: tripleoupstream/centos-binary-nova-consoleauth:latest
- imagename: tripleoupstream/centos-binary-nova-libvirt:latest
- imagename: tripleoupstream/centos-binary-nova-novncproxy:latest
- imagename: tripleoupstream/centos-binary-nova-placement-api:latest
- imagename: tripleoupstream/centos-binary-nova-scheduler:latest
- imagename: tripleoupstream/centos-binary-panko-api:latest
- imagename: tripleoupstream/centos-binary-rabbitmq:latest
- imagename: tripleoupstream/centos-binary-redis:latest
- imagename: tripleoupstream/centos-binary-swift-account:latest
- imagename: tripleoupstream/centos-binary-swift-container:latest
- imagename: tripleoupstream/centos-binary-swift-object:latest
- imagename: tripleoupstream/centos-binary-swift-proxy-server:latest


Expected results:

I would expect it to look something more like


$ openstack overcloud container image prepare --pull-source registry.access.redhat.com --prefix openstack --namespace rhosp12                                                                                           
container_images:
- imagename: rhosp12/openstack-aodh-api:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-aodh-evaluator:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-aodh-listener:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-aodh-notifier:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-ceilometer-central:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-ceilometer-compute:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-ceilometer-notification:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-cron:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-glance-api:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-gnocchi-api:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-gnocchi-metricd:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-gnocchi-statsd:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-haproxy:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-heat-api-cfn:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-heat-api:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-heat-engine:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-horizon:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-keystone:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-mariadb:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-memcached:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-nova-api:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-nova-compute:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-nova-conductor:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-nova-consoleauth:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-nova-libvirt:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-nova-novncproxy:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-nova-placement-api:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-nova-scheduler:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-panko-api:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-rabbitmq:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-redis:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-swift-account:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-swift-container:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-swift-object:latest
  pull_source: registry.access.redhat.com
- imagename: rhosp12/openstack-swift-proxy-server:latest
  pull_source: registry.access.redhat.com


Additional info:

Comment 1 Jon Schlueter 2017-11-03 14:37:16 UTC
Also the ceph container should come from 

registry.access.redhat.com/rhceph/rhceph-2-rhel7:latest

Comment 2 Jon Schlueter 2017-11-03 15:34:59 UTC
2 things I think recommendation is to combine pull_source and namespace together

When enabling ceph we need to make sure ceph from redhat registry is defaulted correctly

$ openstack overcloud container image prepare --pull-source registry.access.redhat.com --prefix openstack --namespace rhosp12 -e /usr/share/openstack-tripleo-heat-templates/environments/ceph-ansible/ceph-ansible.yaml

...
- imagename: docker.io/ceph/daemon:tag-stable-3.0-jewel-centos-7
  pull_source: registry.access.redhat.com


Expected:
$ openstack overcloud container image prepare --namespace brew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888/rhosp12 --prefix openstack --tag 20171102.1 --set ceph_namespace=brew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888/rhceph --set ceph_tag=2.4-4 -e /usr/share/openstack-tripleo-heat-templates/environments/ceph-ansible/ceph-ansible.yaml 

- imagename: brew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888/rhceph/daemon:2.4-4

Comment 3 Jon Schlueter 2017-11-03 16:32:51 UTC
pull_source is deprecated need to roll into namespace  instead.

Comment 4 Jon Schlueter 2017-11-06 18:56:50 UTC
Found 3 additional entries in THT that also directly spell out tripleoupstream or centos-binary

Comment 5 Jon Schlueter 2017-11-06 19:16:33 UTC
tripleo client also has several defaults for tripleoupstream

Comment 7 Jon Schlueter 2017-11-10 13:48:54 UTC
openstack-tripleo-common-7.6.3-0.20171028055751.el7ost

Comment 9 Omri Hochman 2017-11-22 15:10:38 UTC
Verified with : openstack-tripleo-common-7.6.3-3.el7ost.noarch


[root@undercloud74 ~]# openstack overcloud container image prepare
container_images:
- imagename: registry.access.redhat.com/rhosp12/openstack-aodh-api:latest
- imagename: registry.access.redhat.com/rhosp12/openstack-aodh-evaluator:latest
- imagename: registry.access.redhat.com/rhosp12/openstack-aodh-listener:latest
- imagename: registry.access.redhat.com/rhosp12/openstack-aodh-notifier:latest
- imagename: registry.access.redhat.com/rhosp12/openstack-ceilometer-central:latest
- imagename: registry.access.redhat.com/rhosp12/openstack-ceilometer-compute:latest
- imagename: registry.access.redhat.com/rhosp12/openstack-ceilometer-notification:latest
- imagename: registry.access.redhat.com/rhosp12/openstack-cron:latest

Comment 12 errata-xmlrpc 2017-12-13 22:19:18 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:3462