Bug 1509478

Summary:	libffado FTBFS on f27 and rawhide
Product:	[Fedora] Fedora	Reporter:	Merlin Mathesius <mmathesi>
Component:	libffado	Assignee:	Brendan Jones <brendan.jones.it>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	27	CC:	brendan.jones.it, nphilipp, oget.fedora
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libffado-2.3.0-7.fc27	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-11-14 00:55:33 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Merlin Mathesius 2017-11-03 21:36:39 UTC

Description of problem:
libffado no longer builds on Fedora F27 or Rawhide. The last successful build was in August 11, 2017 for F27.

Version-Release number of selected component (if applicable):
libffado-2.3.0-6.fc28
libffado-2.3.0-6.fc27

How reproducible:
always

Steps to Reproduce:
1. fedpkg clone libffado
2. cd libffado
3. fedpkg scratch-build
4. fedpkg --release f27 scratch-build

Actual results:
Failed Rawhide build: https://koji.fedoraproject.org/koji/taskinfo?taskID=22897975
Failed F27 build: https://koji.fedoraproject.org/koji/taskinfo?taskID=22898241

Expected results:
Successful package build

Additional info:
Package still builds successfully for F26: https://koji.fedoraproject.org/koji/taskinfo?taskID=22898895

The issue appears to be that F27 and Rawhide only have scons-3.x available in the buildroot, but the SConstruct file within the libffado package source is compatible only with scons-2.x.

Comment 1 Orcan Ogetbil 2017-11-05 20:07:44 UTC

I spent about an hour for this. Apart from converting Python2 prints to Python3 prints, there are a lot of other incompatibilities that need to be addressed, e.g. some functions expect bytes whereas the current buildsystem sends in strings. 

It is not trivial work to update the build scripts to Scons3. Will Fedora ship a scons2 legacy version? This looks like the easiest solution.

Comment 2 Merlin Mathesius 2017-11-06 14:51:24 UTC

Unfortunately, I know nothing of the plans for scons. However, I did run across BZ#1507581 that is related to mypaint also FTBFS with scons3.

Comment 3 Orcan Ogetbil 2017-11-07 04:56:58 UTC

I managed to make a patch with bunch of workarounds to build libffado with scons3 (patch sent upstream). It skips a few checks during the initial setup, but it completes the build now which is certainly better than FTBFS. 
When upstream switches to scons3, we will have a better solution.
Submitting an update shortly.

Comment 4 Fedora Update System 2017-11-07 05:10:42 UTC

libffado-2.3.0-7.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-afe600fd53

Comment 5 Merlin Mathesius 2017-11-07 14:21:04 UTC

That's great! Thank you for the prompt fix/workaround.

Comment 6 Fedora Update System 2017-11-07 19:14:39 UTC

libffado-2.3.0-7.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-afe600fd53

Comment 7 Fedora Update System 2017-11-14 00:55:33 UTC

libffado-2.3.0-7.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2017-11-14 09:23:32 UTC

libffado-2.3.0-7.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.