Bug 1509680

Summary: ansible_service_broker_registry_user and ansible_service_broker_registry_password shouldn't be required fields for dockerhub type
Product: OpenShift Container Platform Reporter: Zhang Cheng <chezhang>
Component: Service BrokerAssignee: Fabian von Feilitzsch <fabian>
Status: CLOSED CURRENTRELEASE QA Contact: Zhang Cheng <chezhang>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.7.0CC: aos-bugs, jmatthew, qixuan.wang
Target Milestone: ---   
Target Release: 3.7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-11-10 21:00:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1507617    
Bug Blocks:    

Comment 1 Fabian von Feilitzsch 2017-11-06 18:16:30 UTC
https://github.com/openshift/openshift-ansible/pull/6026

Comment 3 openshift-github-bot 2017-11-06 21:20:44 UTC
Commits pushed to master at https://github.com/openshift/openshift-ansible

https://github.com/openshift/openshift-ansible/commit/b27f719acfc00e6891799cec5979c7d0c503301c
Bug 1509680- Fix ansible-service-broker registry validations

- Remove outdated dockerhub registry validations
- Add the local openshift registry by default
  - Add whitelist parameter for local registry
- Set default dockerhub org to ansibleplaybookbundle

https://github.com/openshift/openshift-ansible/commit/b1c349dfd774199125033d76a31a90daa09a8a9c
Merge pull request #6026 from fabianvf/1509680-asb-credential-check

Bug 1509680- Fix ansible-service-broker registry settings/validations

Comment 4 Zhang Cheng 2017-11-07 02:45:50 UTC
PR was not merged in openshift-ansible-3.7.0-0.196.0.git.0.27cd7ec.el7.noarch.rpm

Will verify until code is merged.

Comment 5 Zhang Cheng 2017-11-08 03:28:05 UTC
Verify depend on BZ https://bugzilla.redhat.com/show_bug.cgi?id=1510706 "Installing OCP with ASB failed with latest openshift-ansible, 3.7.0-0.197.0"

Comment 6 Zhang Cheng 2017-11-08 06:58:51 UTC
ansible-service-broker deploy failed while using openshift-ansible with latest build openshift-ansible-3.7.0-0.197.0

Refer to bug: https://bugzilla.redhat.com/show_bug.cgi?id=1507617

Comment 7 Zhang Cheng 2017-11-09 02:40:52 UTC
Re-test and verified with openshift-ansible-3.7.4-1
Ansible job succeed without ansible_service_broker_registry_user and ansible_service_broker_registry_password while using dockerhub type