Bug 1509888

Description of problem:
Red Hat IT raised concern over rpm scripting:

Iterating over ls output is fragile. Use globs.

Reference
- https://github.com/koalaman/shellcheck/wiki/SC2045

Quoting:

Please consider changing /etc/init.d/gluster-system-settings from:

#!/bin/bash
# 
# chkconfig: 35 99 12
# description: Configure sysctl settings to optimize Gluster I/O
#

for i in $(ls -d /sys/block/*/queue/iosched 2>/dev/null); do
    iosched_dir=$(echo $i | awk '/iosched/ {print $1}')
    [ -z $iosched_dir ] && {
  continue
    }
    path=$(dirname $iosched_dir)
    [ -f $path/scheduler ] && {
  echo "deadline" > $path/scheduler
    }
done

modprobe fuse;

if ! grep -q Gluster /etc/security/limits.conf ; then
    echo '* - core unlimited # added by Gluster' >> /etc/security/limits.conf
fi


to:


#!/bin/bash
#
# chkconfig: 35 99 12
# description: Configure sysctl settings to optimize Gluster I/O
#

for i in /sys/block/*/queue/iosched; do
  iosched_dir=$(echo ${i} | awk '/iosched/ {print $1}')
  [ -z ${iosched_dir} ] && {
    continue
  }
  path=$(dirname ${iosched_dir})
  [ -f ${path}/scheduler ] && {
    echo "deadline" > ${path}/scheduler
  }
done

modprobe fuse;

if ! grep -q Gluster /etc/security/limits.conf ; then
  echo '* - core unlimited # added by Gluster' >> /etc/security/limits.conf
fi