Bug 1510054

Summary:	Do not purge session if there are no sessions
Product:	Red Hat CloudForms Management Engine	Reporter:	Satoe Imaishi <simaishi>
Component:	Performance	Assignee:	Keenan Brock <kbrock>
Status:	CLOSED ERRATA	QA Contact:	Tasos Papaioannou <tpapaioa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	5.8.0	CC:	cpelland, jhardy, kbrock, obarenbo, simaishi, tpapaioa
Target Milestone:	GA	Keywords:	ZStream
Target Release:	5.8.3
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	5.8.3.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1510040	Environment:
Last Closed:	2018-02-28 13:07:52 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	CFME Core	Target Upstream Version:
Embargoed:
Bug Depends On:	1510040
Bug Blocks:

Comment 2 CFME Bot 2017-11-06 16:11:19 UTC

New commit detected on ManageIQ/manageiq/fine:
https://github.com/ManageIQ/manageiq/commit/15889ffdf20cdd4f13a11c00a19b931f0808e13e

commit 15889ffdf20cdd4f13a11c00a19b931f0808e13e
Author:     Martin Povolny <mpovolny>
AuthorDate: Tue May 16 15:39:19 2017 +0200
Commit:     Satoe Imaishi <simaishi>
CommitDate: Mon Nov 6 11:06:28 2017 -0500

    Merge pull request #15064 from isimluk/avoid-queue-overhead-if-session-is-turned-off
    
    Performance: Do not schedule Session.purge if this Session is not used
    (cherry picked from commit 493a4884dfd141d7cb3640446d35738c67e42e69)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1510054

 app/models/miq_schedule_worker/runner.rb | 10 ++++++----
 app/models/session.rb                    |  4 ++++
 2 files changed, 10 insertions(+), 4 deletions(-)

Comment 3 Keenan Brock 2018-01-19 18:26:57 UTC

Sorry, should have moved to POST last year

This is a discrete change, and we created a BZ for informational purposes more than testing purposes.

Comment 4 Tasos Papaioannou 2018-01-24 17:54:59 UTC

Verified on 5.8.3.1.

With 

  :session_store: sql

evm.log shows Session.check_session_timeout gets regularly queued.

Comment 7 errata-xmlrpc 2018-02-28 13:07:52 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:0374