Bug 1510188

Summary:	Review Request: python-asttokens - Module to annotate Python abstract syntax trees with source code positions
Product:	[Fedora] Fedora	Reporter:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	eclipseo, package-review
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-11-21 23:29:34 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1501802
Bug Blocks:	1508184

Description Zbigniew Jędrzejewski-Szmek 2017-11-06 21:39:58 UTC

Spec URL: https://in.waw.pl/~zbyszek/fedora/python-asttokens.spec
SRPM URL: https://in.waw.pl/~zbyszek/fedora/python-asttokens-1.1.6-1.fc28.src.rpm

Description:
The asttokens module annotates Python abstract syntax trees (ASTs)
with the positions of tokens and text in the source code that
generated them. This makes it possible for tools that work with
logical AST nodes to find the particular text that resulted in those
nodes, for example for automated refactoring or highlighting.

Fedora Account System Username: zbyszek

Comment 1 Robert-André Mauchin 🐧 2017-11-07 13:06:38 UTC

Hello,

 - We generally use Pythonhosted to avoid dealing with the file sum in the URL:

Source0:        https://files.pythonhosted.org/packages/source/a/asttokens/asttokens-%{version}.tar.gz

 - You could use %{py2_dist/%{py3_dist macros as specified in https://fedoraproject.org/wiki/Packaging:Python#Requires_and_BuildRequires_with_standardized_names

BuildRequires:  %{py2_dist nose}
BuildRequires:  %{py3_dist nose}
BuildRequires:  %{py2_dist astroid}
BuildRequires:  %{py3_dist astroid}
BuildRequires:  %{py2_dist six}
BuildRequires:  %{py3_dist six}


There are no blocking issues so the package is accepted.

Comment 2 Zbigniew Jędrzejewski-Szmek 2017-11-07 14:24:50 UTC

Thanks. I updated the package based on your comments and will push that.

Comment 3 Gwyn Ciesla 2017-11-07 15:16:36 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-asttokens

Comment 4 Zbigniew Jędrzejewski-Szmek 2017-11-09 15:58:29 UTC

F27 builds are blocked.

Comment 5 Fedora Update System 2017-11-09 20:26:16 UTC

python-asttokens-1.1.6-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-254e907606

Comment 6 Fedora Update System 2017-11-09 20:26:24 UTC

python-asttokens-1.1.6-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-131a73f9b8

Comment 7 Fedora Update System 2017-11-11 17:30:34 UTC

python-asttokens-1.1.6-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-254e907606

Comment 8 Fedora Update System 2017-11-12 02:40:06 UTC

python-asttokens-1.1.6-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-131a73f9b8

Comment 9 Fedora Update System 2017-11-21 23:29:34 UTC

python-asttokens-1.1.6-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2017-11-22 02:27:29 UTC

python-asttokens-1.1.6-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.