Bug 1510392

Summary:	Build option -DLEATHERMAN_USE_CATCH=OFF breaks dependent builds
Product:	[Fedora] Fedora	Reporter:	James Hogarth <james.hogarth>
Component:	leatherman	Assignee:	Gwyn Ciesla <gwync>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	gwync
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-11-07 10:50:30 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1506504

Description James Hogarth 2017-11-07 10:08:18 UTC

Description of problem:
Packages depending on leatherman just #include <catch.hpp> and expect it to be part of leatherman.

The build option removes it entirely so it cannot be relied on anymore.

As it's just used for testing and no part of the compiled lib it's safe to not enforce an unbundling to remove it.

See breakage here: 
https://kojipkgs.fedoraproject.org//work/tasks/768/22970768/build.log

See working version here:
https://copr-be.cloud.fedoraproject.org/results/jhogarth/facter3/fedora-rawhide-x86_64/00652818-cpp-hocon/build.log.gz

Comment 1 James Hogarth 2017-11-07 10:50:30 UTC

Since this is breaking the build of my new package I'm fixing this as a ProvenPackager.

Feel free to tweak my fix if you need to.

I'm only making the fix in rawhide as that's where I need to build facter3.