Bug 1510710

Summary:	recipe with custom partitions fails on x86 EFI machine if NETBOOT_METHOD=grub2
Product:	[Retired] Beaker	Reporter:	Dan Callaghan <dcallagh>
Component:	general	Assignee:	Dan Callaghan <dcallagh>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Anwesha Chatterjee <achatter>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	24	CC:	achatter, dcallagh, mjia, rjoost
Target Milestone:	25.0	Keywords:	Patch
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-03-19 04:18:43 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dan Callaghan 2017-11-08 03:43:47 UTC

Description of problem:


Version-Release number of selected component (if applicable):
24.5

How reproducible:
with some effort, if you have suitable hardware

Steps to Reproduce:
1. Have an x86 system with EFI firmware (booting in EFI mode specifically)
2. Configure it in DHCP to use GRUB2 *or* configure to use "switchable boot loader" and set netbootloader=boot/grub2/x86_64-efi/core.efi
(see: https://beaker-project.org/docs/admin-guide/tftp.html#boot-loader-images )
3. Run inventory scan on the system, so that its NETBOOT_METHOD key is set to "grub2"
4. Try to run a recipe on it which uses custom partitioning (any <partition/> element or ks_meta="fstype=xfs" etc)

Actual results:
Installation fails. Anaconda says:

04:53:05,312 ERR anaconda: BootLoader setup failed: failed to find a suitable stage1 device

which really means that the custom partitioning commands in the kickstart failed to configure an EFI System Partition:

...
part biosboot --size 1 --fstype biosboot
part /boot --recommended --asprimary
part / --size 1024 --grow
part swap --recommended
part /lol --size=5120
...

Expected results:
EFI System Partition should be configured, installation should work.

Additional info:
system.has_efi property is looking for NETBOOT_METHOD=efigrub but not NETBOOT_METHOD=grub2. Need to add grub2 also.

Comment 1 Dan Callaghan 2017-11-08 04:16:24 UTC

https://gerrit.beaker-project.org/5919

Comment 3 Anwesha Chatterjee 2018-01-09 07:38:05 UTC

Verified by submitting the following job XML on beaker-devel (forcing use of hp-dl120gen9-06.rhts.eng.bos.redhat.com as the system as it has grub2 netboot method):

```
<job retention_tag="scratch">
  <whiteboard>test for https://bugzilla.redhat.com/show_bug.cgi?id=1510710</whiteboard>
  <recipeSet priority="High">
    <recipe whiteboard="STANDALONE" role="None" ks_meta="" kernel_options="" kernel_options_post="">
      <autopick random="false"/>
      <watchdog panic="None"/>
      <packages/>
      <ks_appends/>
      <repos/>
      <distroRequires>
           <distro_name op="=" value="RHEL-6.2"/>
           <distro_variant op="=" value="Server"/>
           <distro_arch op="=" value="x86_64"/>
      </distroRequires>
      <hostRequires force="hp-dl120gen9-06.rhts.eng.bos.redhat.com"/>
      <partitions>
           <partition fs="ext4" name="mnt" size="10"/>
           </partitions>
      <task name="/distribution/install" role="STANDALONE"/>
    </recipe>
  </recipeSet>
</job>
```  


Installation proceeded with Boot Mode: UEFI,
and rendered kickstart contained the following line:

`part /boot/efi --fstype vfat --size 250 --recommended`

Comment 4 Dan Callaghan 2018-02-06 00:36:03 UTC

This bug was fixed on the release-24 branch, to appear in Beaker 24.6, but we are not planning any more maintenance releases for the 24.x series. The next release will be Beaker 25.0. Updating the milestone accordingly.

Comment 5 Roman Joost 2018-03-19 04:18:43 UTC

Beaker 25.0 has been released.

Release notes are available upstream: https://beaker-project.org/docs/whats-new/release-25.html