Bug 1511779

Summary:	Garbage collect inactive inodes in fuse-bridge
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	Raghavendra G <rgowdapp>
Component:	fuse	Assignee:	Amar Tumballi <atumball>
Status:	CLOSED ERRATA	QA Contact:	Vinayak Papnoi <vpapnoi>
Severity:	high	Docs Contact:
Priority:	high
Version:	rhgs-3.3	CC:	amukherj, atumball, ccalhoun, guillaume.pavese, knoha, nchilaka, olim, pasik, rcyriac, rhs-bugs, sankarshan, sheggodu, smali, srengan, srmukher, storage-qa-internal, vpapnoi
Target Milestone:	---	Keywords:	FutureFeature, ZStream
Target Release:	RHGS 3.4.z Batch Update 4
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.12.2-41	Doc Type:	Enhancement
Doc Text:	This release introduces a garbage collection logic in glusterfs client processes. This feature reduces the overall memory usage of glusterfs client and makes sure to keep the memory consumption of glusterfs inside a limit.	Story Points:	---
Clone Of:
Clones:	1560969 (view as bug list)		Environment:
Last Closed:	2019-03-27 03:43:36 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1560969, 1647277, 1689046

Description Raghavendra G 2017-11-10 06:24:35 UTC

Description of problem:
Currently fuse-bridge has an lru limit of the inode table as infinite. This means we are dependent on kernel to send forgets even though the inode is not active. However, we can implement garbage collection of inodes in lru list of itable. We can ask kernel to send a forget by calling inode/entry_invalidate on the inode.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 3 Amar Tumballi 2018-11-26 09:27:05 UTC

*** Bug 1579151 has been marked as a duplicate of this bug. ***

Comment 11 Amar Tumballi 2019-02-26 06:41:41 UTC

This is good for validating this feature.

But to be complete, you need to complete negative tests, like, giving it an option of negative values. String values, etc and see how the process takes it.

Comment 12 Vinayak Papnoi 2019-02-27 09:29:04 UTC

Tried mounting the volume using the '-olru-limit' option with invalid inputs for the option.
Following are the observations:

1. Alphabets as inputs
 - Mount fails with "glusterfs: unknown LRU limit option abc" error

2. Special characters as inputs (eg. %, &, !, @, etc.)
 - Mount fails with "glusterfs: unknown LRU limit option !" error

3. Decimal values (eg. 1.5)
 - Mount fails with "glusterfs: unknown LRU limit option 1.5" error

4. Empty string as value
 - Error message is displayed as "Invalid option lru-limit". Although there is no mount failed message, the output of "df" command doesn't list the mount and the mount is unsuccessful.

Polarion test case has been attached with the bug, please review the test case.

Comment 14 Amar Tumballi 2019-03-04 08:58:54 UTC

Vinayak,

Looks fine about invalid option tests.

As a add-on one can run memory consumption runs in longevity tests, where there are more than a million files being used. I am fine to mark this bug as VERIFIED.

Comment 15 Vinayak Papnoi 2019-03-05 06:35:02 UTC

Based on comment 10 , comment 12 and comment 14 , moving this bug to VERIFIED.

Comment 20 Srijita Mukherjee 2019-03-22 08:31:52 UTC

Thanks for reviewing the doctext.

Comment 23 errata-xmlrpc 2019-03-27 03:43:36 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0658

Comment 24 Amar Tumballi 2019-04-30 16:43:58 UTC

Cal, Sorry missed your needinfo earlier. Yes, this addresses the concerns raised in bz1632465. Please let customer know that client memory usage is controlled now onwards from RHGS 3.4.4 releases.

Will also close the bug (1632465) as CURRENT_RELEASE for reducing the confusion.