Bug 1512875
Summary: | WARNING: CPU: 7 PID: 1090 at drivers/target/target_core_transport.c:3009 __transport_check_aborted_status+0x153/0x190 [target_core_mod] | ||
---|---|---|---|
Product: | Red Hat Enterprise Linux 7 | Reporter: | Zhang Yi <yizhan> |
Component: | kernel-rt | Assignee: | Arnaldo Carvalho de Melo <acme> |
kernel-rt sub component: | Kernel-rt Target (LIO) | QA Contact: | Zhang Yi <yizhan> |
Status: | CLOSED ERRATA | Docs Contact: | |
Severity: | unspecified | ||
Priority: | unspecified | CC: | bhu, cleech, daolivei, jkastner, lgoncalv, williams, yizhan |
Version: | 7.5 | ||
Target Milestone: | rc | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | No Doc Update | |
Doc Text: |
undefined
|
Story Points: | --- |
Clone Of: | Environment: | ||
Last Closed: | 2018-10-30 09:40:30 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1532680 |
Description
Zhang Yi
2017-11-14 11:41:36 UTC
Assigning to an RT engineer. An rpm with a patch converting that WARN_ON_ONCE() to the _NONRT() variant is available for testing at: http://people.redhat.com/acme/torture/RPMS/x86_64/kernel-rt-3.10.0-843.rt56.784.test.el7.x86_64.rpm Please let me know if it is possible to test it or alternatively to loan me the machines and provide instructions about how to test it myself. (In reply to Arnaldo Carvalho de Melo from comment #3) > An rpm with a patch converting that WARN_ON_ONCE() to the _NONRT() variant > is available for testing at: > > http://people.redhat.com/acme/torture/RPMS/x86_64/kernel-rt-3.10.0-843.rt56. > 784.test.el7.x86_64.rpm > > Please let me know if it is possible to test it or alternatively to loan me > the machines and provide instructions about how to test it myself. Cannot reproduce this issue with above kernel, thanks. Yi The solution proposed by Arnaldo was included in kernel-rt-3.10.0-863.rt56.805.el7 as this commit: a6196419b848 target: No need to WARN_ON if !irqs_disabled() when checking aborted status The full commit is: commit a6196419b8480dcf483a1ea2073a57cb6874af81 Author: Arnaldo Carvalho de Melo <acme> Date: Wed Feb 28 11:13:49 2018 -0300 target: No need to WARN_ON if !irqs_disabled() when checking aborted status Since we already require that cmd->t_state_lock be held. This was introduced in commit 310d3d314be7 ("target: Fix race with SCF_SEND_DELAYED_TAS handling"). Reported at https://bugzilla.redhat.com/show_bug.cgi?id=1512875 Signed-off-by: Arnaldo Carvalho de Melo <acme> diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c index dd6fd003860f..e6b25d9dff21 100644 --- a/drivers/target/target_core_transport.c +++ b/drivers/target/target_core_transport.c @@ -3008,7 +3008,7 @@ static int __transport_check_aborted_status(struct se_cmd *cmd, int send_status) __acquires(&cmd->t_state_lock) { assert_spin_locked(&cmd->t_state_lock); - WARN_ON_ONCE(!irqs_disabled()); + WARN_ON_ONCE_NONRT(!irqs_disabled()); if (!(cmd->transport_state & CMD_T_ABORTED)) return 0; Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2018:3096 |