Bug 1512929

Summary: Incorrect <target type='isa-serial'/> for <serial> element of mach-virt guests
Product: Red Hat Enterprise Linux 7 Reporter: Andrea Bolognani <abologna>
Component: libvirtAssignee: Andrea Bolognani <abologna>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: high Docs Contact:
Priority: high    
Version: 7.5CC: abologna, dyuan, hhuang, mtessun, mzhan, rbalakri, weizhan, xuzhang
Target Milestone: rcKeywords: OtherQA
Target Release: ---   
Hardware: aarch64   
OS: Linux   
Whiteboard:
Fixed In Version: libvirt-3.9.0-4.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-04-10 11:00:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Andrea Bolognani 2017-11-14 13:10:36 UTC
If a serial console is added to a mach-virt guest with

  <console type='pty'>
    <target type='serial'/>
  </console>

the <serial> element auto-generated by libvirt will look like

  <serial type='pty'>
    <target type='isa-serial' port='0'/>
  </serial>

While the serial console will work thanks to workarounds present
in the code, isa-serial is clearly the incorrect type (mach-virt
guests don't have an ISA bus) and a more appropriate type should
be used instead.

Comment 2 Andrea Bolognani 2017-11-15 11:53:42 UTC
Patches posted upstream.

  https://www.redhat.com/archives/libvir-list/2017-November/thread.html

Comment 3 Andrea Bolognani 2017-11-15 11:54:58 UTC
Wrong link :/

  https://www.redhat.com/archives/libvir-list/2017-November/msg00545.html

Comment 4 Andrea Bolognani 2017-11-28 15:30:23 UTC
Fixed upstream.

commit eccdcb81fcfd1641960d397c82986b4517841794
Author: Andrea Bolognani <abologna>
Date:   Thu Nov 9 17:14:57 2017 +0100

    conf: Add target type and model for pl011
    
    We can finally introduce a specific target model for the pl011 device
    used by mach-virt guests, which means isa-serial will no longer show
    up to confuse users.
    
    We make sure migration works in both directions by interpreting the
    isa-serial target type, or the lack of target type, appropriately
    when parsing the guest XML, and skipping the newly-introduced type
    when formatting if for migration. We also verify that pl011 is not
    used for non-mach-virt guests and add a bunch of test cases.
    
    Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=151292
    
    Signed-off-by: Andrea Bolognani <abologna>
    Reviewed-by: Pavel Hrdina <phrdina>

v3.9.0-261-geccdcb81f

Yes, the Bugzilla link in the commit message is missing one digit :(

Comment 13 errata-xmlrpc 2018-04-10 11:00:58 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:0704