Bug 1512957
| Summary: | [Regression] Diagnostics pagination pane is displayed in Settings | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Matouš Mojžíš <mmojzis> | ||||||
| Component: | UI - OPS | Assignee: | Martin Hradil <mhradil> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Matouš Mojžíš <mmojzis> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | 5.9.0 | CC: | cpelland, dajohnso, ewinchel, hkataria, jhardy, mhradil, mmojzis, mpovolny, obarenbo | ||||||
| Target Milestone: | GA | Keywords: | Regression, TestOnly | ||||||
| Target Release: | 5.10.0 | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | ui:configuration:diagnostics | ||||||||
| Fixed In Version: | 5.10.0.0 | Doc Type: | If docs needed, set a value | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | |||||||||
| : | 1536062 (view as bug list) | Environment: | |||||||
| Last Closed: | 2018-06-21 20:28:24 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | CFME Core | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1536062 | ||||||||
| Attachments: |
|
||||||||
|
Description
Matouš Mojžíš
2017-11-14 14:01:08 UTC
Created attachment 1352089 [details]
pagination at top of gtl
Screenshot of Settings page after going from Workers page attached. See the pagination pane - has same number of items in item count as it is in Workers page. Created attachment 1352090 [details]
pagination pane in settings page
New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/69419c02ce2bcd596e5539ed0e42403e100df447 commit 69419c02ce2bcd596e5539ed0e42403e100df447 Author: Martin Hradil <mhradil> AuthorDate: Wed Jan 17 15:15:29 2018 +0000 Commit: Martin Hradil <mhradil> CommitDate: Wed Jan 17 15:16:54 2018 +0000 gtl - miqGtlSetExtraClasses as a way to call setExtraClasses without a ReportController instance on screens without GTL, we may still need to clean the paging toolbar setExtraClasses (without params) does the right thing .. but assumes an instance created a function that runs it with a fake instance https://bugzilla.redhat.com/show_bug.cgi?id=1512957 app/assets/javascripts/controllers/report_data_controller.js | 7 +++++++ 1 file changed, 7 insertions(+) New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/fe9921dcf0c0ff5badead03103b4df1c5f0f63b7 commit fe9921dcf0c0ff5badead03103b4df1c5f0f63b7 Author: Martin Hradil <mhradil> AuthorDate: Wed Jan 17 15:20:35 2018 +0000 Commit: Martin Hradil <mhradil> CommitDate: Wed Jan 17 15:39:50 2018 +0000 OpsController#handle_bottom_cell - use remove_paging instead of hide(:pc_div_1) pc_div_#(number) used to be a div under paging_div but above the pagination code this was removed with the GTL refactor thus, attempts to show/hide pc_div_1 are dead code, but indicate that those were the places where paging was being hidden replaced by explicit remove_paging Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1512957 app/controllers/ops_controller.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) |