Bug 1513024

Summary:	Changing blivet imports in the install class
Product:	[Fedora] Fedora	Reporter:	Vendula Poncova <vponcova>
Component:	anaconda	Assignee:	Vendula Poncova <vponcova>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	anaconda-maint-list, awilliam, jkonecny, jonathan, kellin, lnie, mattdm, mkolman, robatino, sgallagh, vanmeeuwen+fedora, vpodzime, vponcova, wwoods
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	AcceptedBlocker
Fixed In Version:	anaconda-28.11-1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1513025 1513028 (view as bug list)		Environment:
Last Closed:	2017-12-12 15:13:19 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1469204, 1513025, 1513028

Description Vendula Poncova 2017-11-14 15:39:15 UTC

Hello,
your install class imports some of the modules that are moved from blivet to anaconda since anaconda-28.10 and blivet-3.0:

https://koji.fedoraproject.org/koji/buildinfo?buildID=997184
https://koji.fedoraproject.org/koji/buildinfo?buildID=997157

The install class needs to change these imports:

from blivet.partspec import PartSpec
from blivet.autopart import swap_suggestion
from blivet.platform import platform

Therefore, we would like to remind you of the following bugs, where we suggest moving the install classes to anaconda:

https://bugzilla.redhat.com/show_bug.cgi?id=1491241 (fedora-productimg-server)
https://bugzilla.redhat.com/show_bug.cgi?id=1491284 (fedora-productimg-workstation)
https://bugzilla.redhat.com/show_bug.cgi?id=1491285 (fedora-productimg-cloud)
https://bugzilla.redhat.com/show_bug.cgi?id=1491287 (fedora-productimg-atomic)

We are making significant changes to the installer backend, which will have a potentially disruptive impact on install classes in the future. Migrating them to anaconda now prevents some extra work and headaches for you in the future, since we will be able to adapt them to changes right away.

Comment 1 Vendula Poncova 2017-11-15 15:05:05 UTC

The install class was moved to anaconda.

Comment 2 Vendula Poncova 2017-11-15 15:05:43 UTC

Fixed in a pull request: https://github.com/rhinstaller/anaconda/pull/1234

Comment 3 Adam Williamson 2017-11-28 17:55:36 UTC

This prevents the Server netinst and DVD installer images from booting in the latest Rawhide compose:

https://openqa.fedoraproject.org/tests/176198#step/_boot_to_anaconda/10

That's an automatic Beta blocker, per https://fedoraproject.org/wiki/QA:SOP_blocker_bug_process#Automatic_blockers - "Complete failure of any release-blocking TC/RC image to boot at all under any circumstance - "DOA" image (conditional failure is not an automatic blocker)"

Comment 4 Jiri Konecny 2017-11-29 08:32:02 UTC

*** Bug 1518540 has been marked as a duplicate of this bug. ***

Comment 5 Jiri Konecny 2017-11-29 08:35:10 UTC

Should be fixed by bug 1491241 .

Comment 6 Martin Kolman 2017-12-12 15:13:19 UTC

This should be long fixed by Anaconda version in Rawhide.