Bug 1513290
| Summary: | Review Request: ocaml-oasis - Tooling for building OCaml libraries and applications | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Andy Li <andy> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | eclipseo, package-review, robinlee.sysu |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | eclipseo:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-01-16 16:52:01 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Andy Li
2017-11-15 05:52:22 UTC
There's a rpmlint error: ocaml-oasis.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/oasis missing-call-to-chdir-with-chroot: This executable appears to call chroot without using chdir to change the current directory. This is likely an error and permits an attacker to break out of the chroot by using fchdir. While that's not always a security issue, this has to be checked. I don't think oasis ever calls chroot: https://github.com/ocaml/oasis/search?utf8=%E2%9C%93&q=chroot&type= It does call chdir though: https://github.com/ocaml/oasis/search?utf8=%E2%9C%93&q=chdir&type= It seems like a common false-positive: https://bugzilla.redhat.com/show_bug.cgi?id=1396563 Hmmm, okay, package accepted then. (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ocaml-oasis ocaml-oasis-0.4.10-3.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-1b7266f53e ocaml-oasis-0.4.10-3.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-1b7266f53e ocaml-oasis-0.4.10-3.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. ocaml-oasis-0.4.10-3.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-afda83891b ocaml-oasis-0.4.10-3.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-afda83891b ocaml-oasis-0.4.10-3.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-afda83891b ocaml-oasis-0.4.10-3.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. |