Bug 1513337
| Summary: | lldpad killed by SIGSEGV [rhel-7.9.z] | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Denis Silakov <dsilakov> | ||||||||
| Component: | lldpad | Assignee: | Aaron Conole <aconole> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Matt Lucius <malucius> | ||||||||
| Severity: | high | Docs Contact: | |||||||||
| Priority: | high | ||||||||||
| Version: | 7.4 | CC: | aconole, gerben, jbainbri, jpeska, jpittman, kpfleming, kzhang, loberman, malucius, mleitner, qe-baseos-daemons, todoleza, vcojot | ||||||||
| Target Milestone: | rc | Keywords: | OtherQA, Reopened, Triaged, ZStream | ||||||||
| Target Release: | --- | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2022-08-09 11:54:25 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Denis Silakov
2017-11-15 08:51:01 UTC
Created attachment 1352445 [details]
Possible patch
Created attachment 1380451 [details]
Improved patch
Improved version of the patch. Should handle all possible failures we met in our tests.
Works great on Debian package as well, thanks! Created attachment 1613291 [details]
LLDPAD with proposed fix
We have a customer reporting this and I had given them a fix similar to this, but John Pittman then found this bug. Customer is on 7.7. Is the latest version of lldpad fixed now meaning this bug can be closed errata Hello
Customer experienced this in 7.7 and I checked the latest package available and the fix is not in.
I had come up with a similar fix to the BZ here and gave them a test package.
The latest revision of this package is not fixed
lldpad-1.0.1-5.git036e314.el7.src.rpm
{
struct ecp22_user_data *eud;
struct ecp22 *ecp;
LLDPAD_DBG("%s:%s start ecp\n", __func__, ifname);
eud = find_module_user_data_by_id(&lldp_head, LLDP_MOD_ECP22);
if (!eud) {
LLDPAD_DBG("%s:%s no ECP module\n", __func__, ifname);
return;
}
ecp = find_ecpdata(ifname, eud);
if (!ecp)
ecp = ecp22_create(ifname, eud);
The fix I gave them is this and its needed because they use docker and interfaces can leave the configuration.
void ecp22_start(char *ifname)
{
struct ecp22_user_data *eud;
struct ecp22 *ecp;
LLDPAD_DBG("%s:%s start ecp\n", __func__, ifname);
eud = find_module_user_data_by_id(&lldp_head, LLDP_MOD_ECP22);
if (!eud) {
LLDPAD_DBG("%s:%s no ECP module\n", __func__, ifname);
return;
}
ecp = find_ecpdata(ifname, eud);
if (!ecp)
ecp = ecp22_create(ifname, eud); /*** This is never checked for NULL ***/
if (!ecp) /*** If null because interface is gone just return **/
Opening again Hi Aaron, could you please look at this and apply the patch from upstream for the next zstream? Thanks! Hello Given this change is only specific to lldpad and that its not a kernel change so very narrow exposure we are asking to get this into the latest possible change for 7.9 zstream please. No luck so far reproducing using the information provided, including Aaron's suggestion to repeatedly bounce the IPv6 address. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (lldpad bug fix and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2022:5940 |