Bug 1515213

Summary: Send password in API function for new user just once
Product: [Red Hat Storage] Red Hat Gluster Storage Reporter: Filip Balák <fbalak>
Component: web-admin-tendrl-apiAssignee: Shirshendu Mukherjee <smukherj>
Status: CLOSED ERRATA QA Contact: sds-qe-bugs
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rhgs-3.3CC: nthomas, rhs-bugs, sankarshan, smukherj
Target Milestone: ---   
Target Release: RHGS 3.4.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: tendrl-ansible-1.6.1-2.el7rhgs.noarch.rpm, tendrl-api-1.6.1-1.el7rhgs.noarch.rpm, tendrl-commons-1.6.1-1.el7rhgs.noarch.rpm, tendrl-monitoring-integration-1.6.1-1.el7rhgs.noarch.rpm, tendrl-node-agent-1.6.1-1.el7, tendrl-ui-1.6.1-1.el7rhgs.noarch.rpm, Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-09-04 06:58:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1503134    

Description Filip Balák 2017-11-20 12:10:18 UTC
Description of problem:
Create user API call requires to specify parameters `password` and `password_confirmation`. There should be provided only `password` parameter and confirmation of matching passwords should be held on the front-end side.

Version-Release number of selected component (if applicable):
tendrl-selinux-1.5.3-2.el7rhgs.noarch
tendrl-commons-1.5.4-3.el7rhgs.noarch
tendrl-api-httpd-1.5.4-2.el7rhgs.noarch
tendrl-grafana-selinux-1.5.3-2.el7rhgs.noarch
tendrl-ansible-1.5.4-1.el7rhgs.noarch
tendrl-node-agent-1.5.4-3.el7rhgs.noarch
tendrl-ui-1.5.4-3.el7rhgs.noarch
tendrl-grafana-plugins-1.5.4-4.el7rhgs.noarch
tendrl-notifier-1.5.4-2.el7rhgs.noarch
tendrl-api-1.5.4-2.el7rhgs.noarch
tendrl-monitoring-integration-1.5.4-4.el7rhgs.noarch


How reproducible:
100%

Steps to Reproduce:
1. Check in Tendrl that there is no user called thardy.
2. Send API call like this (with valid access token):
```
curl -H 'Content-Type: application/json' -H 'Authorization: Bearer
d03ebb195dbe6385a7caeda699f9930ff2e49f29c381ed82dc95aa642a7660b8'
-XPOST -d '{"name":"Tom Hardy", "username":"thardy",
"email":"thardy", "role":"admin", "password":"pass1234",
"email_notifications": true}'
http://127.0.0.1/api/1.0/users
```
3. Send API call like this (with valid access token):
```
curl -H 'Content-Type: application/json' -H 'Authorization: Bearer
d03ebb195dbe6385a7caeda699f9930ff2e49f29c381ed82dc95aa642a7660b8'
-XPOST -d '{"name":"Tom Hardy", "username":"thardy",
"email":"thardy", "role":"admin", "password":"pass1234",
"password_confirmation":"pass1234","email_notifications": true}'
http://127.0.0.1/api/1.0/users
```

Actual results:
API call from step 2 fails because there was not provided parameter `password_confirmation`. API call from step 3 succeeds.

Expected results:
API call from step 2 should succeed.

Additional info:
https://github.com/Tendrl/api/blob/master/docs/users.adoc#create-user

Comment 3 Filip Balák 2018-03-13 14:15:14 UTC
Looks ok. --> VERIFIED
This should be handled also by UI. --> created BZ 1554882.

Tested with:
tendrl-ansible-1.6.1-2.el7rhgs.noarch
tendrl-api-1.6.1-1.el7rhgs.noarch
tendrl-api-httpd-1.6.1-1.el7rhgs.noarch
tendrl-commons-1.6.1-1.el7rhgs.noarch
tendrl-grafana-plugins-1.6.1-1.el7rhgs.noarch
tendrl-grafana-selinux-1.5.4-2.el7rhgs.noarch
tendrl-monitoring-integration-1.6.1-1.el7rhgs.noarch
tendrl-node-agent-1.6.1-1.el7rhgs.noarch
tendrl-notifier-1.6.0-1.el7rhgs.noarch
tendrl-selinux-1.5.4-2.el7rhgs.noarch
tendrl-ui-1.6.1-1.el7rhgs.noarch

Comment 5 errata-xmlrpc 2018-09-04 06:58:45 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:2616