Bug 1515972

Summary:	Review Jenkins JNLP slave setup script
Product:	OpenShift Container Platform	Reporter:	Jim Minter <jminter>
Component:	Build	Assignee:	Jim Minter <jminter>
Status:	CLOSED ERRATA	QA Contact:	Wenjing Zheng <wzheng>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	aos-bugs, dyan, erich, gmontero, jminter, rromerom, sreber, vwalek
Target Milestone:	---
Target Release:	3.9.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-03-28 14:13:03 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jim Minter 2017-11-21 17:26:08 UTC

- Look for opportunities to simplify the run-jnlp-client code
- Confirm why are we setting -Xms, what effect it has and if it is needed
- Allow -Xmx=<amount> to be specified as a specific amount, not just a % of container size
- Consider capping % of container size calculation for large containers (i.e. min(% * container size, 256MB)
- Consider master switch for disabling all smarts
- Consider not using JAVA_OPTS as an environment variable name as it might conflict with spawned Java processes
- Investigate how to tune based on container *request*, not container limits, e.g. using downward API
- Investigate if setting additional environment variable presets would make sense for subsequent workload (JAVA_OPTS, MAVEN_OPTS, GRADLE_OPTS, JAVA_TOOL_OPTIONS, _JAVA_OPTIONS?)

Comment 1 Gabe Montero 2017-11-27 14:54:45 UTC

some bugzilla maintenance per request from Paul Weil wrt bugs with no target and 3.7 closing up ... setting this untargetted bug to post 3.7

Comment 2 Jim Minter 2017-12-18 19:20:40 UTC

https://github.com/openshift/jenkins/pull/442

Comment 5 Jim Minter 2018-01-08 19:12:50 UTC

Trello card: https://trello.com/c/SvSBSkOy/1425-8-jenkins-memory-cleanup-evg

Comment 7 Dongbo Yan 2018-01-10 05:29:53 UTC

Test with
openshift3/jenkins-2-rhel7:v3.9(4e3dc986043c)
openshift3/jenkins-slave-base-rhel7:v3.9(3b1e124d2bcd)
openshift3/jenkins-slave-maven-rhel7:v3.9(aa5c4ce0e097)

could move to verified

Comment 13 errata-xmlrpc 2018-03-28 14:13:03 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0489