Bug 1516283

Description of problem:

The nfp driver uses a similar model of creating multiple netdevs per physical PCI function that mlxsw* and rocker drivers use.

Upstream systemd provides support for consistent naming of these multiple netdevs in https://github.com/systemd/systemd/blob/master/src/udev/udev-builtin-net_id.c based on phys_port_id.

Unfortunately, enabling this globally caused regressions in other drivers, as documented in:

https://access.redhat.com/articles/3154771

The nfp driver in RHEL 7.4 does not expose phys_port_name for its netdevs, but the proposed module in RHEL 7.5 will.

Would it be possible to add an exception line to /usr/lib/udev/rules.d/76-phys-port-name.rules for the "nfp*" series drivers? This would cover nfp and nfp_netvf (if phys_port_name is used there in the future).

Version-Release number of selected component (if applicable):

systemd-219-42.el7_4.4.x86_64 is affected

How reproducible:

100% reproducable

Steps to Reproduce:

Boot using RHEL 7.4.1

Actual results:

(in this case)
netdevs are named enp5s0 and eth<x>

Expected results:

netdevs are named enp5s0np0 and enp5s0np1

Additional info:

This is a summary of the proposed change:

/usr/lib/udev/rules.d/76-phys-port-name.rules

--- /usr/lib/udev/rules.d/76-phys-port-name.rules.orig	2017-11-22 11:51:40.381455942 +0200
+++ /usr/lib/udev/rules.d/76-phys-port-name.rules	2017-11-22 11:51:52.587506052 +0200
@@ -2,6 +2,7 @@
 ACTION!="add", GOTO="phys_port_name_end"
 SUBSYSTEM!="net", GOTO="phys_port_name_end"

+DRIVERS=="nfp*", ATTR{phys_port_name}=="?*", IMPORT{program}="/usr/lib/udev/phys-port-name-gen %k"
 DRIVERS=="mlxsw*", ATTR{phys_port_name}=="?*", IMPORT{program}="/usr/lib/udev/phys-port-name-gen %k"
 DRIVERS=="rocker", ATTR{phys_port_name}=="?*", IMPORT{program}="/usr/lib/udev/phys-port-name-gen %k"