Bug 1516546

Summary: rubygem-cucumber: HTML injection in HTML formatter message output
Product: [Other] Security Response Reporter: Pedro Sampaio <psampaio>
Component: vulnerabilityAssignee: Red Hat Product Security <security-response-team>
Status: CLOSED WONTFIX QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: unspecifiedCC: ccoleman, clalancette, dedgar, dmcphers, hhorak, jaruga, jgoulding, jorton, mmorsi, pvalena, ruby-maint, scorneli, tdawson, vondruch
Target Milestone: ---Keywords: Security
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: rubygem-cucumber 3.1.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-02-27 00:49:18 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1516547, 1516548    
Bug Blocks: 1516549    

Description Pedro Sampaio 2017-11-22 21:31:43 UTC 
A flaw was found in cucumber HTML formatter. It appends any scenario output to the HTML without escaping HTML tags in the messages. This means that any output from the steps gets injected into the report page and could lead to cross-site scripting attacks.
Comment 1 Pedro Sampaio 2017-11-22 21:32:31 UTC 
Created rubygem-cucumber tracking bugs for this issue:

Affects: epel-7 [bug 1516548]
Affects: fedora-all [bug 1516547]
Comment 2 Stefan Cornelius 2017-11-29 10:38:20 UTC 
Patch:
https://github.com/cucumber/cucumber-ruby/commit/a6ddc2c03a813c1f13559951ef546875c3cda4bb
Comment 3 Stefan Cornelius 2017-11-29 11:18:14 UTC 
Statement:

Red Hat Product Security has rated this issue as having Moderate security impact. This issue is not currently planned to be addressed in future updates. For additional information, refer to the Issue Severity Classification: https://access.redhat.com/security/updates/classification/.
Comment 4 Pavel Valena 2017-12-08 14:26:22 UTC 
Note that cucumber is usually used solely for writing tests[1] and not for rendering any production website code (or similar).

[1] https://github.com/cucumber/cucumber-ruby#cucumber