Bug 1517073

Summary: In CF 4.5 , custom report is not able to be shown in "Available Reports" option in "Edit Report Menus"
Product: Red Hat CloudForms Management Engine Reporter: tachoi
Component: UI - OPSAssignee: Harpreet Kataria <hkataria>
Status: CLOSED CURRENTRELEASE QA Contact: Niyaz Akhtar Ansari <nansari>
Severity: high Docs Contact:
Priority: high    
Version: 5.8.0CC: cpelland, hkataria, jhardy, mpovolny, obarenbo
Target Milestone: GAKeywords: Regression, TestOnly
Target Release: 5.10.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.10.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1519984 (view as bug list) Environment:
Last Closed: 2018-06-21 20:55:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1519984    
Attachments:
Description Flags
issue screenshot on 4.5
none
worksfine in CF4.2
none
custom-report none

Description tachoi 2017-11-24 07:01:03 UTC
Description of problem:
In CF 4.5.x, custom report is not able to be shown in "Available Reports" option in "Edit Report Menus"
CF 4.2.x works fine.

Version-Release number of selected component (if applicable):
CF 4.5.1

How reproducible:
1. Create Custom Chargeback Report(or any Custom report)
- https://access.redhat.com/articles/1291563
2. Trying to add Reports to Report Menus
- Custom report is not available from "Available Reports" menu.

Steps to Reproduce:
1.
2.
3.

Actual results:
Custom Report is not shown under "Available Reports"

Expected results:
Custom Report should be shown under "Available Reports"

Additional info:

Comment 2 tachoi 2017-11-24 07:04:26 UTC
Created attachment 1358497 [details]
issue screenshot on 4.5

Comment 3 tachoi 2017-11-24 07:05:02 UTC
Created attachment 1358498 [details]
worksfine in CF4.2

Comment 4 tachoi 2017-11-24 07:05:38 UTC
Created attachment 1358499 [details]
custom-report

Comment 6 tachoi 2017-11-30 00:23:47 UTC
Hi Team

Any update on this issue?

Regards,
Taeho

Comment 7 Harpreet Kataria 2017-12-01 19:16:29 UTC
https://github.com/ManageIQ/manageiq-ui-classic/pull/2905

Comment 9 CFME Bot 2017-12-01 21:00:49 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/75814925a5de0e2c9146e67e57e1f0b53c43c7a6

commit 75814925a5de0e2c9146e67e57e1f0b53c43c7a6
Author:     Harpreet Kataria <hkataria>
AuthorDate: Fri Dec 1 12:15:42 2017 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Fri Dec 1 12:21:51 2017 -0500

    Fixed code to show Custom reports in Available Reports in menu editor
    
    Also fixed saving of reports menus for a selected group that broke with changes in https://github.com/ManageIQ/manageiq/pull/16142
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1517073

 app/controllers/application_controller.rb       |  4 +++-
 app/controllers/report_controller/menus.rb      | 12 +++++-----
 spec/controllers/report_controller/menu_spec.rb | 31 +++++++++++++++++++++++++
 3 files changed, 40 insertions(+), 7 deletions(-)

Comment 10 CFME Bot 2017-12-01 21:00:54 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/59846235fa9d45ece1047655e4d45abe147d8a14

commit 59846235fa9d45ece1047655e4d45abe147d8a14
Author:     Harpreet Kataria <hkataria>
AuthorDate: Fri Dec 1 13:16:57 2017 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Fri Dec 1 13:16:57 2017 -0500

    Adjusted existing spec tests to run with new changes
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1517073

 app/controllers/report_controller.rb                 | 2 +-
 spec/controllers/miq_report_controller/trees_spec.rb | 2 +-
 spec/controllers/report_controller_spec.rb           | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)