Bug 1517938

Summary: [REGRESSION] Production settings are not being honored
Product: Red Hat CloudForms Management Engine Reporter: Leo Khomenko <lkhomenk>
Component: ProvidersAssignee: Jason Frey <jfrey>
Status: CLOSED CURRENTRELEASE QA Contact: Dave Johnson <dajohnso>
Severity: medium Docs Contact:
Priority: high    
Version: 5.9.0CC: cpelland, gblomqui, gtanzill, hkataria, jfrey, jhardy, mpovolny, obarenbo
Target Milestone: GAKeywords: Regression, TestOnly
Target Release: 5.10.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: regression:amazon:azure
Fixed In Version: 5.10.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1518290 (view as bug list) Environment:
Last Closed: 2018-06-21 20:35:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: Azure Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1518290    

Comment 4 Jason Frey 2017-11-27 21:07:53 UTC
This seems like a bigger problem in that none of the production settings are being honored at all.

Comment 5 Jason Frey 2017-11-27 21:19:13 UTC
I think I know what the problem is.

https://github.com/ManageIQ/manageiq-providers-azure/blob/master/config/settings.yml#L32  contains an empty Array as the default, and the production.yml override is being evaluated at a lower precedence for some reason.

Comment 7 CFME Bot 2017-11-28 14:16:50 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/63759e4176421b7189af7fe7aa1c83e60f322a81

commit 63759e4176421b7189af7fe7aa1c83e60f322a81
Author:     Jason Frey <jfrey>
AuthorDate: Mon Nov 27 18:07:12 2017 -0500
Commit:     Jason Frey <jfrey>
CommitDate: Mon Nov 27 18:11:10 2017 -0500

    Fix issue where plugin settings had higher precedence than manageiq
    
    One of the side effects of this is that in production deployments with
    overrides, the overrides were being clobbered by the plugins.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1517938

 lib/vmdb/settings.rb | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)