Bug 1518390
Summary: | Dynamic Dialog Elements not populating | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Red Hat CloudForms Management Engine | Reporter: | Brant Evans <brant.evans> | ||||||||||
Component: | Automate | Assignee: | eclarizi | ||||||||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | Shveta <sshveta> | ||||||||||
Severity: | urgent | Docs Contact: | |||||||||||
Priority: | urgent | ||||||||||||
Version: | 5.9.0 | CC: | brant.evans, cpelland, jhardy, mkanoor, obarenbo, tfitzger | ||||||||||
Target Milestone: | GA | Keywords: | Regression, TestOnly | ||||||||||
Target Release: | 5.10.0 | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Whiteboard: | |||||||||||||
Fixed In Version: | 5.10.0.0 | Doc Type: | If docs needed, set a value | ||||||||||
Doc Text: | Story Points: | --- | |||||||||||
Clone Of: | |||||||||||||
: | 1520678 (view as bug list) | Environment: | |||||||||||
Last Closed: | 2019-02-11 13:55:45 UTC | Type: | Bug | ||||||||||
Regression: | --- | Mount Type: | --- | ||||||||||
Documentation: | --- | CRM: | |||||||||||
Verified Versions: | Category: | --- | |||||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||
Cloudforms Team: | CFME Core | Target Upstream Version: | |||||||||||
Embargoed: | |||||||||||||
Bug Depends On: | |||||||||||||
Bug Blocks: | 1520678 | ||||||||||||
Attachments: |
|
Description
Brant Evans
2017-11-28 19:58:48 UTC
Hi Brant, Can you send us the evm.log/automation.log and the /Test-a-Thon/Integration/RedHat/CloudForms/DynamicDropDowns/available_clusters Automate method? Thanks, Tina Created attachment 1360418 [details]
automation.log
Created attachment 1360419 [details]
evm.log
Created attachment 1360421 [details]
available_clusters.rb
Hi Tina, The requested files have been attached. Regards, Brant Hey Brant, does the dialog just have one field with a drop-down or is it more complex than that? If it's more complex can you export it and post here? I feel like this title is a bit misleading because I have a couple of dialogs with dynamic elements and their data seems to load just fine without running the automate method twice. I'm unsure of the reasoning behind why yours is running twice at the moment. Created attachment 1360451 [details]
Sample Dialog
Erik, I have attached the dialog I used to test this. It does have a couple of non-dynamic elements and one dynamic element. I am doing nothing to cause CF to run the dynamic method twice. It just happens. You can see in the logs that when the dialog loads the dynamic method(s) are run twice. Regards, Brant Jillian and I think we have determined the root cause and the above PR will need to be combined with my forthcoming PR to have this fully fixed. New commit detected on ManageIQ/manageiq-api/master: https://github.com/ManageIQ/manageiq-api/commit/b100aa7fa6989d8f8241597001cce2de3b5587c7 commit b100aa7fa6989d8f8241597001cce2de3b5587c7 Author: Jillian Tullo <jtullo> AuthorDate: Wed Nov 29 14:07:30 2017 -0500 Commit: Jillian Tullo <jtullo> CommitDate: Wed Nov 29 15:21:39 2017 -0500 Specify a target and resource action when retrieving a service dialog Fetching the content from a resource sometimes requires both a target and resource_action, where we are currently passing in nil values. By accepting resource_action_id, target_type, and target_id, we are able to use resource search to pass in the applicable values. https://bugzilla.redhat.com/show_bug.cgi?id=1518390 app/controllers/api/service_dialogs_controller.rb | 14 ++++++++++++- spec/requests/service_dialogs_spec.rb | 25 +++++++++++++++++++++++ 2 files changed, 38 insertions(+), 1 deletion(-) New commit detected on ManageIQ/manageiq-api/master: https://github.com/ManageIQ/manageiq-api/commit/0cbec91e77592212c0b6c11e6216b33fe8853af2 commit 0cbec91e77592212c0b6c11e6216b33fe8853af2 Author: Erik Clarizio <eclarizio> AuthorDate: Fri Dec 1 11:07:56 2017 -0800 Commit: Erik Clarizio <eclarizio> CommitDate: Fri Dec 1 15:35:25 2017 -0800 Specify a target and resource when refreshing a dialog field https://bugzilla.redhat.com/show_bug.cgi?id=1518390 app/controllers/api/service_dialogs_controller.rb | 27 ++++++------ spec/requests/service_dialogs_spec.rb | 51 +++++++++++++++++++++-- 2 files changed, 61 insertions(+), 17 deletions(-) New commit detected on ManageIQ/manageiq-api/master: https://github.com/ManageIQ/manageiq-api/commit/574e63dedec37e071da6ad83606b72bc55e2fd9e commit 574e63dedec37e071da6ad83606b72bc55e2fd9e Author: Erik Clarizio <eclarizio> AuthorDate: Mon Dec 4 11:00:01 2017 -0800 Commit: Erik Clarizio <eclarizio> CommitDate: Mon Dec 4 12:25:11 2017 -0800 Ensure dialog passed in and resource action dialog are the same https://bugzilla.redhat.com/show_bug.cgi?id=1518390 app/controllers/api/service_dialogs_controller.rb | 11 +++++++++-- spec/requests/service_dialogs_spec.rb | 15 +++++++++++++++ 2 files changed, 24 insertions(+), 2 deletions(-) New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/d7c7f9c2b4070e871a68717640ee0b2a7431184c commit d7c7f9c2b4070e871a68717640ee0b2a7431184c Author: Erik Clarizio <eclarizio> AuthorDate: Thu Nov 30 09:49:25 2017 -0800 Commit: Erik Clarizio <eclarizio> CommitDate: Fri Dec 1 09:19:11 2017 -0800 Pass additional information to the API when ordering a service catalog https://bugzilla.redhat.com/show_bug.cgi?id=1518390 Resource action id, target id, and target type need to be passed in order to establish the context that some dynamic methods may use when going through automate. .../controllers/dialog_user/dialog_user_controller.js | 9 +++++++-- app/controllers/application_controller/buttons.rb | 7 +++++-- app/controllers/catalog_controller.rb | 7 ++++++- app/views/shared/dialogs/_dialog_provision.html.haml | 9 ++++++++- app/views/shared/dialogs/_dialog_user.html.haml | 5 ++++- .../controllers/dialog_user/dialog_user_controller.spec.js | 11 +++++++++-- 6 files changed, 39 insertions(+), 9 deletions(-) New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/bcfee500c1650fb1d8f0af8164dfd484c5029414 commit bcfee500c1650fb1d8f0af8164dfd484c5029414 Author: Erik Clarizio <eclarizio> AuthorDate: Fri Dec 1 09:18:39 2017 -0800 Commit: Erik Clarizio <eclarizio> CommitDate: Fri Dec 1 09:19:11 2017 -0800 Extract dialog local logic and add specs around it https://bugzilla.redhat.com/show_bug.cgi?id=1518390 app/controllers/application_controller/buttons.rb | 34 +--------- app/controllers/catalog_controller.rb | 13 +--- app/services/dialog_local_service.rb | 47 +++++++++++++ spec/services/dialog_local_service_spec.rb | 81 +++++++++++++++++++++++ 4 files changed, 134 insertions(+), 41 deletions(-) create mode 100644 app/services/dialog_local_service.rb create mode 100644 spec/services/dialog_local_service_spec.rb New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/cad3a3966e814d571d16d27fc869a18b9443ef12 commit cad3a3966e814d571d16d27fc869a18b9443ef12 Author: Erik Clarizio <eclarizio> AuthorDate: Fri Dec 1 10:23:15 2017 -0800 Commit: Erik Clarizio <eclarizio> CommitDate: Mon Dec 4 09:34:33 2017 -0800 Pass additional information when refreshing a dialog field https://bugzilla.redhat.com/show_bug.cgi?id=1518390 As before, resource action id, target id, and target type need to be passed to the API in order to establish the context for dialog fields when they are refreshed via the /service_dialogs endpoint .../controllers/dialog_user/dialog_user_controller.js | 9 ++++++++- .../javascripts/services/dialog_field_refresh_service.js | 7 +++++-- app/controllers/catalog_controller.rb | 6 +++++- .../controllers/dialog_user/dialog_user_controller.spec.js | 2 +- .../services/dialog_field_refresh_service_spec.js | 14 +++++++++++--- 5 files changed, 30 insertions(+), 8 deletions(-) Values are loaded properly in 5.10.0.2.20180626170006_40dc459 |