Bug 1518582

Summary:	Reduce lock contention on fdtable lookup
Product:	[Community] GlusterFS	Reporter:	Zhang Huan <zhhuan>
Component:	core	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-4.0.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-03-15 11:22:12 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Zhang Huan 2017-11-29 09:08:22 UTC

Description of problem:

To resolve a fd from client requests, need to take a mutex lock for the fdtable to do the lookup. When a user is busy doing read and write, the mutex lock could introduce contention.

Version-Release number of selected component (if applicable):
mainline

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2017-11-29 09:10:28 UTC

REVIEW: https://review.gluster.org/18887 (libglusterfs: use rwlock for fdtable) posted (#1) for review on master by Zhang Huan

Comment 2 Worker Ant 2017-11-30 12:35:10 UTC

COMMIT: https://review.gluster.org/18887 committed in master by \"Zhang Huan\" <zhanghuan> with a commit message- libglusterfs: use rwlock for fdtable

To resolve a fd from client requests, need to take a mutex lock for the
fdtable to do the lookup. When a client is busy doing read and write,
the mutex lock could introduce contention. Therefore, use rwlock instead
of mutex to reduce the contention.

Change-Id: Ic833aed738a178a7ea1abafed7eb13814989d28c
BUG: 1518582
Signed-off-by: Zhang Huan <zhanghuan>

Comment 3 Shyamsundar 2018-03-15 11:22:12 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-4.0.0, please open a new bug report.

glusterfs-4.0.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2018-March/000092.html
[2] https://www.gluster.org/pipermail/gluster-users/