Bug 1518724

Summary: [UI] UI plugins can no longer add buttons / context menu items
Product: [oVirt] ovirt-engine Reporter: Greg Sheremeta <gshereme>
Component: Frontend.WebAdminAssignee: Alexander Wels <awels>
Status: CLOSED CURRENTRELEASE QA Contact: Pavel Novotny <pnovotny>
Severity: high Docs Contact:
Priority: high    
Version: 4.2.0CC: bugs, lsvaty
Target Milestone: ovirt-4.2.0Flags: rule-engine: ovirt-4.2+
pnovotny: testing_plan_complete-
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-12-22 06:50:29 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: UX RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Screenshot-of-added-buttons-overflowing-line none

Description Greg Sheremeta 2017-11-29 14:05:27 UTC 
Description of problem:
UI plugins can no longer add buttons / context menu items
Reported by Martin Sivak here: http://lists.ovirt.org/pipermail/devel/2017-November/032077.html

Version-Release number of selected component (if applicable):
4.2 master 13908b5

How reproducible:
always

Steps to Reproduce:
1. install a UI plugin that adds menu options, example ovirt optimized

Actual results:
Menu options / context menu options are missing

Expected results:
Menu options / context menu options should exist
Comment 1 Martin Sivák 2017-11-30 15:42:31 UTC 
Created attachment 1360979 [details]
Screenshot-of-added-buttons-overflowing-line

The latest version seems to have the buttons, but they are not grouped under the three dots and make the whole button line overflow.
Comment 2 Pavel Novotny 2017-12-20 22:05:11 UTC 
Verified in
ovirt-engine-4.2.0.2-0.1.el7.noarch
ovirt-engine-webadmin-portal-4.2.0.2-0.1.el7.noarch

Buttons defined by a UI plugin in the action menu or context menu are back.

I have installed the ovirt-optimizer UI plugin [1] for verification and buttons Optimize Start and Cancel Optimization are present in the menu bar and in the context menu (Virtual Machines view).

[1] https://www.ovirt.org/develop/release-management/features/sla/optaplanner/#installing-the-ovirt-optimizer-machine


Additional note:
(In reply to Martin Sivák from comment #1)
> Created attachment 1360979 [details]
> Screenshot-of-added-buttons-overflowing-line
> 
> The latest version seems to have the buttons, but they are not grouped under
> the three dots and make the whole button line overflow.

Martin, the overflowing action buttons is common behavior.
Depending on the browser window width, the buttons are not hidden under the kebab menu (the three dots) but they wrap to the next line.
Comment 3 Sandro Bonazzola 2017-12-22 06:50:29 UTC 
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.