Bug 1518851

Summary:	[GSS](6.4.z) Add CriticalAnalyzer to TimedBuffer operations follow up to BZ1487313
Product:	[JBoss] JBoss Enterprise Application Platform 6	Reporter:	Tom Ross <tom.ross>
Component:	JMS	Assignee:	jboss-set
Status:	CLOSED CURRENTRELEASE	QA Contact:	Peter Mackay <pmackay>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	6.4.18	CC:	bmaxwell, csuconic, dosoudil, jbilek, jmesnil
Target Milestone:	CR1
Target Release:	EAP 6.4.19
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-04-16 11:03:27 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1487313
Bug Blocks:	1498153, 1498190

Description Tom Ross 2017-11-29 16:18:40 UTC

The stop() method on TimedBuffer class should be added to critical path of CriticalAnalyzer and it should be synchronised.

Comment 2 Clebert Suconic 2017-11-30 15:03:01 UTC

This is being applied in Artemis: https://github.com/apache/activemq-artemis/pull/1681


It is already applied in hornetq: 

commit d4c29e29c472ba90f313c774cd0f96f62006ff12
Author: Clebert Suconic <clebertsuconic>
Date:   Wed Nov 29 14:58:07 2017 -0500

    BZ-1518851 & BZ-1487313 Fixing TimedBuffer and File Sync
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1518851
    https://bugzilla.redhat.com/show_bug.cgi?id=1487313

Comment 5 Jiří Bílek 2018-01-17 09:18:31 UTC

Verified with EAP 6.4.19.CP.CR2

Note: Included test is not executed automatically with any profile. Here is PR https://github.com/hornetq/hornetq/pull/2126 with fix.