Bug 1519359

Summary:	Azure provider allows validation with no Subscription ID
Product:	Red Hat CloudForms Management Engine	Reporter:	Russ Builta <rbuilta>
Component:	UI - OPS	Assignee:	Richard Vsiansky <rvsiansk>
Status:	CLOSED ERRATA	QA Contact:	Angelina Vasileva <anikifor>
Severity:	low	Docs Contact:
Priority:	low
Version:	5.9.0	CC:	bsorota, cpelland, dmetzger, gblomqui, hkataria, jfrey, jhardy, lavenel, mpovolny, mshriver, obarenbo, simaishi
Target Milestone:	GA
Target Release:	5.11.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.11.0.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-12-12 13:33:21 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	Bug
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	CFME Core	Target Upstream Version:
Embargoed:

Description Russ Builta 2017-11-30 16:09:08 UTC

Description of problem:
When editing the Azure provider - you can delete the Subscription ID, validate and save. The validation works as well as "Refresh Relationships and Power States"


Version-Release number of selected component (if applicable):


How reproducible: Everytime


Steps to Reproduce:
1. Add Azure provider
2. Edit Azure provider and remove the Subscription ID
3. Validate
4. Save
5. Refresh Relationships and Power States


Actual results: Validation succeeds and allows save


Expected results: Should fail with no Subscription ID 


Additional info:

Comment 2 Bronagh Sorota 2018-03-21 17:05:53 UTC

I think the subscription ID on an existing provider should be read only. Modifying the subscription id value on an existing EMS would alter the inventory we collect from the provider.

Sending to the UI team.

Comment 7 CFME Bot 2019-03-20 14:26:50 UTC

https://github.com/ManageIQ/manageiq-ui-classic/pull/5359

Comment 8 CFME Bot 2019-03-21 13:12:52 UTC

New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/95df1ce6912b8498258212f72aeeb1f4c5c3aa11
commit 95df1ce6912b8498258212f72aeeb1f4c5c3aa11
Author:     Richard Vsiansky <r.vsia>
AuthorDate: Wed Mar 20 10:10:43 2019 -0400
Commit:     Richard Vsiansky <r.vsia>
CommitDate: Wed Mar 20 10:10:43 2019 -0400

    Subscription ID is required when adding, readOnly when editing (Azure)

    fixes https://bugzilla.redhat.com/show_bug.cgi?id=1519359

 app/views/shared/views/ems_common/angular/_form.html.haml | 4 +
 1 file changed, 4 insertions(+)

Comment 9 Angelina Vasileva 2019-05-06 09:07:41 UTC

Fixed and verified in 5.11.0.2.20190430174828_0e34dea.
Subscription ID is a read only field when editing Azure provider.

Comment 11 errata-xmlrpc 2019-12-12 13:33:21 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:4199