Bug 1519494

Summary: [RFE] Generic Object builder tab cycle missing the add (commit) remove buttons
Product: Red Hat CloudForms Management Engine Reporter: Jeff Warnica <jwarnica>
Component: UI - OPSAssignee: Eric Winchell <ewinchel>
Status: CLOSED NOTABUG QA Contact: Dave Johnson <dajohnso>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.9.0CC: awight, cpelland, dmetzger, ewinchel, hkataria, jhardy, lavenel, mfeifer, mpovolny, obarenbo
Target Milestone: GAKeywords: FutureFeature, TestOnly, ZStream
Target Release: 5.12.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1767823 (view as bug list) Environment:
Last Closed: 2020-03-20 15:33:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1767823    

Description Jeff Warnica 2017-11-30 18:57:42 UTC 
Description of problem:
Adding or editing a Generic Object requires a mix of keyboard and mouse actions.


Version-Release number of selected component (if applicable):
5.9.0.11.20171127204214_e316988

How reproducible:
100%

Steps to Reproduce:
1. Create new or edit existing Generic Object
2. tab through name, description, attribute/name, attribute/type
3. tab to - +

Actual results:
Doesn't tab top buttons

Expected results:
Tabs to buttons

Additional info:
"button" is actually a <div>. In Chrome inspector, changing to <button type="button" ...> (otherwise identical html attributes) has expected behavior.
Comment 2 Allen W 2017-11-30 21:26:28 UTC 
For some reason, looks like button classes were added to `div` elements rather than using a `button` element or giving the element a `type="button"`
Comment 5 CFME Bot 2019-09-23 16:01:13 UTC 
https://github.com/ManageIQ/manageiq-ui-classic/pull/6226
Comment 6 CFME Bot 2019-09-23 18:26:19 UTC 
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/52c843ec48d4b5a6501001fbfdfec6d7edf41df7
commit 52c843ec48d4b5a6501001fbfdfec6d7edf41df7
Author:     Eric Winchell <ewinchel>
AuthorDate: Mon Sep 23 11:51:47 2019 -0400
Commit:     Eric Winchell <ewinchel>
CommitDate: Mon Sep 23 11:51:47 2019 -0400

    Add button tag to generic object form

    https://bugzilla.redhat.com/show_bug.cgi?id=1519494

 app/views/static/generic_object/generic_object_table.html.haml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)