Bug 1520964

Summary:	VMWare WebMKS consoles do not proxy sessions as VNC sessions do in CloudForms
Product:	Red Hat CloudForms Management Engine	Reporter:	Satoe Imaishi <simaishi>
Component:	UI - OPS	Assignee:	Dávid Halász <dhalasz>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Kedar Kulkarni <kkulkarn>
Severity:	high	Docs Contact:
Priority:	high
Version:	5.8.0	CC:	bascar, dclarizi, gblomqui, hkataria, jfrey, jhardy, kkulkarn, lavenel, mpovolny, obarenbo
Target Milestone:	GA
Target Release:	5.9.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.9.0.12	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1504299	Environment:
Last Closed:	2018-03-06 15:11:41 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	VMware	Target Upstream Version:
Embargoed:
Bug Depends On:	1504299
Bug Blocks:

Comment 2 CFME Bot 2017-12-05 14:35:25 UTC

New commit detected on ManageIQ/manageiq-providers-vmware/gaprindashvili:
https://github.com/ManageIQ/manageiq-providers-vmware/commit/1813e6bca12d2df338cca9a7f59ed074536a6130

commit 1813e6bca12d2df338cca9a7f59ed074536a6130
Author:     Adam Grare <agrare>
AuthorDate: Tue Dec 5 09:05:30 2017 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Tue Dec 5 09:34:10 2017 -0500

    Merge pull request #140 from skateman/webmks-proxy
    
    Proxy WebMKS connections through the WebSocket worker
    (cherry picked from commit 6deabdd6ee6e99159cd0638fcd0ca3d6fb118849)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1520964

 .../providers/vmware/infra_manager/vm/remote_console.rb | 17 +++++++++++++++--
 .../vmware/infra_manager/vm/remote_console_spec.rb      |  4 ++--
 2 files changed, 17 insertions(+), 4 deletions(-)

Comment 3 CFME Bot 2017-12-05 14:41:48 UTC

New commit detected on ManageIQ/manageiq/gaprindashvili:
https://github.com/ManageIQ/manageiq/commit/59d2f840432a86900eed91c7f1594ac95a6c3c98

commit 59d2f840432a86900eed91c7f1594ac95a6c3c98
Author:     Martin Povolny <mpovolny>
AuthorDate: Tue Dec 5 15:07:56 2017 +0100
Commit:     Satoe Imaishi <simaishi>
CommitDate: Tue Dec 5 09:32:41 2017 -0500

    Merge pull request #16490 from skateman/websocket-webmks
    
    Allow proxying WebMKS consoles using the WebsocketWorker
    (cherry picked from commit 6421e3ddf8512dc106119347e1dd36729de28f95)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1520964

 lib/websocket_proxy.rb           | 32 +++++++++++++-------------------
 lib/websocket_right.rb           | 14 ++++++++++++++
 lib/websocket_socket.rb          |  9 +++++++++
 lib/websocket_ssl_socket.rb      | 22 ++++++++++++++++++++++
 lib/websocket_webmks.rb          | 30 ++++++++++++++++++++++++++++++
 spec/lib/websocket_proxy_spec.rb | 16 ++++++++--------
 6 files changed, 96 insertions(+), 27 deletions(-)
 create mode 100644 lib/websocket_right.rb
 create mode 100644 lib/websocket_socket.rb
 create mode 100644 lib/websocket_ssl_socket.rb
 create mode 100644 lib/websocket_webmks.rb

Comment 4 CFME Bot 2017-12-05 14:44:41 UTC

New commit detected on ManageIQ/manageiq-ui-classic/gaprindashvili:
https://github.com/ManageIQ/manageiq-ui-classic/commit/5d0e086b0f5cbf18a649de65e3ca44a21b3da04d

commit 5d0e086b0f5cbf18a649de65e3ca44a21b3da04d
Author:     Milan Zázrivec <mzazrivec>
AuthorDate: Tue Dec 5 10:06:15 2017 +0100
Commit:     Satoe Imaishi <simaishi>
CommitDate: Tue Dec 5 09:37:55 2017 -0500

    Merge pull request #2768 from skateman/webmks-proxied
    
    Adjust the remote console views/controllers for WebMKS proxying
    (cherry picked from commit a8407ddad996a4cec631c1fd89ced8bce5e7b285)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1520964

 app/controllers/vm_remote.rb                 | 15 +++++++--------
 app/views/vm_common/console_webmks.html.haml | 11 ++++++++++-
 2 files changed, 17 insertions(+), 9 deletions(-)

Comment 5 Kedar Kulkarni 2017-12-15 19:21:42 UTC

Verified in 5.9.0.13