Bug 1523122

Summary:	fix serval bugs found on testing protocol/client
Product:	[Community] GlusterFS	Reporter:	Zhang Huan <zhhuan>
Component:	protocol	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-v4.1.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-06-20 17:57:42 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Zhang Huan 2017-12-07 09:51:11 UTC

Description of problem:
Found several issues during testing gluster client, in both rpc-clnt and socket.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2017-12-07 10:04:55 UTC

REVIEW: https://review.gluster.org/18984 (protocol/client: fix an issue when a request fails to send) posted (#1) for review on master by Zhang Huan

Comment 2 Worker Ant 2017-12-07 10:05:52 UTC

REVIEW: https://review.gluster.org/18986 (rpc: simplify parameters when a saved frame is forced to unwind) posted (#1) for review on master by Zhang Huan

Comment 3 Worker Ant 2017-12-07 10:06:44 UTC

REVIEW: https://review.gluster.org/18985 (rpc: fix incorrect return value when xdr decode fails) posted (#1) for review on master by Zhang Huan

Comment 4 Worker Ant 2017-12-07 10:07:35 UTC

REVIEW: https://review.gluster.org/18987 (rpc-transport/socket: reconfigure fails if socket is not valid) posted (#1) for review on master by Zhang Huan

Comment 5 Worker Ant 2017-12-28 03:25:22 UTC

REVIEW: https://review.gluster.org/19100 (rpc: fix crash on submiting requests when brick is down) posted (#1) for review on master by Zhang Huan

Comment 6 Worker Ant 2018-03-28 03:10:18 UTC

REVIEW: https://review.gluster.org/18985 (rpc: fix incorrect return value when xdr decode fails) posted (#3) for review on master by Amar Tumballi

Comment 7 Worker Ant 2018-03-28 03:11:21 UTC

REVIEW: https://review.gluster.org/18986 (rpc: simplify parameters when a saved frame is forced to unwind) posted (#3) for review on master by Amar Tumballi

Comment 8 Worker Ant 2018-03-28 03:12:17 UTC

REVIEW: https://review.gluster.org/18984 (protocol/client: fix an issue when a request fails to send) posted (#3) for review on master by Amar Tumballi

Comment 9 Worker Ant 2018-03-28 03:13:12 UTC

REVIEW: https://review.gluster.org/18987 (rpc-transport/socket: reconfigure fails if socket is not valid) posted (#3) for review on master by Amar Tumballi

Comment 10 Worker Ant 2018-03-28 03:15:31 UTC

REVIEW: https://review.gluster.org/19100 (rpc: fix crash on submiting requests when brick is down) posted (#2) for review on master by Amar Tumballi

Comment 11 Worker Ant 2018-03-28 07:38:03 UTC

COMMIT: https://review.gluster.org/18985 committed in master by "Amar Tumballi" <amarts> with a commit message- rpc: fix incorrect return value when xdr decode fails

xdr_replymsg is called to decode reply message, and it returns failure
if the message is corrupted. However, retrieving return value from
the global errno is 0 even xdr_replymsg fails.

Fix this issue by simply returning a negative value if call to
xdr_replymsg fails.

Change-Id: I2b9a1dc97652fbb6cf6568ea617f120713784a55
BUG: 1523122
Signed-off-by: Zhang Huan <zhanghuan>

Comment 12 Worker Ant 2018-03-28 07:38:41 UTC

COMMIT: https://review.gluster.org/18986 committed in master by "Amar Tumballi" <amarts> with a commit message- rpc: simplify parameters when a saved frame is forced to unwind

When a saved frame is to be forced unwind, there is no need to pass an
empty iovector without any data pointed to.

Change-Id: I6e858fb38644326e22239b83272b15db656035e5
BUG: 1523122
Signed-off-by: Zhang Huan <zhanghuan>

Comment 13 Shyamsundar 2018-06-20 17:57:42 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-v4.1.0, please open a new bug report.

glusterfs-v4.1.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2018-June/000102.html
[2] https://www.gluster.org/pipermail/gluster-users/