Bug 1523353

Summary: io-stats bugs and features
Product: [Community] GlusterFS Reporter: Ana M. Neri <amnerip>
Component: io-statsAssignee: bugs <bugs>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-4.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-03-15 11:23:27 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ana M. Neri 2017-12-07 19:34:53 UTC
io-stats bugs and features

Comment 1 Worker Ant 2017-12-07 19:37:39 UTC
REVIEW: https://review.gluster.org/19007 (debug/io-stats: Adding stat for weighted & unweighted average latency) posted (#1) for review on master by

Comment 2 Worker Ant 2017-12-08 02:26:57 UTC
REVIEW: https://review.gluster.org/19009 (debug/io-stats: Track path of operations in FOP samples) posted (#1) for review on master by Shreyas Siravara

Comment 3 Worker Ant 2017-12-08 23:27:00 UTC
REVIEW: https://review.gluster.org/19016 (debug/io-stats: Add errors to FOP samples) posted (#1) for review on master by

Comment 4 Worker Ant 2017-12-09 04:05:18 UTC
COMMIT: https://review.gluster.org/19007 committed in master by  with a commit message- debug/io-stats: Adding stat for weighted & unweighted average latency

Summary:
- Our current approach to measuring "average fop latency" is badly
  flawed in that it doesn't weight the FOPs correctly according to how
  many occurred in the time interval.  This makes Statisticians very
  sad.  This patch adds an internally computed weighted average
  latency which will be far more efficient to display via ODS, as well
  as having the benefit of not being complete nonsense.

Reviewers: kvigor, dph, sshreyas

Reviewed By: sshreyas

Change-Id: Ie3618f279b545610b7ed1a8482243fcc8dc53217
BUG: 1523353
Reviewed-on: https://review.gluster.org/18192
Reviewed-by: Shreyas Siravara <sshreyas>
Smoke: Gluster Build System <jenkins.org>
CentOS-regression: Gluster Build System <jenkins.org>
Signed-off-by: Ana M. Neri <amnerip>

Comment 5 Shyamsundar 2018-03-15 11:23:27 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-4.0.0, please open a new bug report.

glusterfs-4.0.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2018-March/000092.html
[2] https://www.gluster.org/pipermail/gluster-users/