Bug 1523399
| Summary: | KeyError: 'vmName' after starting VM that was restored from snapshot with memory | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [oVirt] vdsm | Reporter: | Raz Tamir <ratamir> | ||||
| Component: | Core | Assignee: | Milan Zamazal <mzamazal> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Raz Tamir <ratamir> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | urgent | ||||||
| Version: | 4.20.9 | CC: | ahadas, bugs, ederevea, michal.skrivanek, ratamir | ||||
| Target Milestone: | ovirt-4.2.0 | Keywords: | Automation, Regression | ||||
| Target Release: | 4.20.9.1 | Flags: | rule-engine:
ovirt-4.2+
rule-engine: blocker+ |
||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2017-12-20 11:25:11 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | Virt | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Raz Tamir
2017-12-07 21:30:43 UTC
works for me In which version was the snapshot created? (In reply to Michal Skrivanek from comment #1) ah, the debug logging is not set up correctly, nevermind the previous question. Raz, can you please make sure the debug log level is enable for api.virt as well? Despite all the storage debug noise we're missing the crucial logs for many other calls (In reply to Michal Skrivanek from comment #2) > (In reply to Michal Skrivanek from comment #1) > ah, the debug logging is not set up correctly, nevermind the previous > question. The snapshot was created in the same version as the engine and vdsm > > Raz, can you please make sure the debug log level is enable for api.virt as > well? Despite all the storage debug noise we're missing the crucial logs for > many other calls Sure, Do you want me to reproduce with DEBUG level for virt? Seems the assumption in https://gerrit.ovirt.org/#/c/84266/ is wrong. The hiberVolHandle volume doesn't contain vmconf, it just contains the libvirt xml (obtained from libvirt on hibernation in both 4.1 and 4.2) Arik, please doublecheck the code in executeVdsBrokerCommand checks properly the compatibility version of that snapshot and not the current VM's compat. (i.e. snapshot taken in 4.1, now the VM is in 4.2 cluster, on preview there should be a warning/note that the VM is going to be restored as a 4.1 compat VM (with cluster level override set to 4.1) - please make sure in that case the vmconf is sent. Once that's correct the vdsm side can safely assume the snapshot is either: - created in 4.1, then engine sends vmconf and the code works as is. The _srcDomXML is used only for libvirt create call. - created in 4.2 and engine doesn't send vmconf - it needs to replace(create) "xml" with _srcDomXML as the current way how to differentiate old from new (if "xml" in params or self.conf) relies on it (In reply to Raz Tamir from comment #3) > Sure, Thanks, it would greatly help with these cases > Do you want me to reproduce with DEBUG level for virt? Currently there's no need to, I believe I was able to deduce what's happening. Let's wait for a fix and try then!:) Applied the patch to one of the hosts and went through the reproducer steps to create the snapshot and switch to it. Attempts to run the VM on a non-patched host fail and succeed on the patched one. Passed automation run on: rhvm-4.2.0.2-0.1.el7.noarch vdsm-4.20.9.2-1.el7ev.x86_64 Verified This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017. Since the problem described in this bug report should be resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report. |