Bug 1523404

Summary: VMWare WebMKS consoles do not proxy sessions as VNC sessions do in CloudForms
Product: Red Hat CloudForms Management Engine Reporter: Satoe Imaishi <simaishi>
Component: UI - OPSAssignee: Dávid Halász <dhalasz>
Status: CLOSED ERRATA QA Contact: Kedar Kulkarni <kkulkarn>
Severity: high Docs Contact:
Priority: high    
Version: 5.8.0CC: alsilva, asilva, bascar, cpelland, dclarizi, gblomqui, greartes, hkataria, jfrey, jhardy, jocarter, kkulkarn, kmorey, lavenel, mpovolny, obarenbo, rspagnol, simaishi, smallamp
Target Milestone: GAKeywords: ZStream
Target Release: 5.8.3   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.8.3.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1504299 Environment:
Last Closed: 2018-02-28 13:11:00 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: VMware Target Upstream Version:
Embargoed:
Bug Depends On: 1504299    
Bug Blocks:    

Comment 2 CFME Bot 2017-12-08 17:15:59 UTC
New commit detected on ManageIQ/manageiq/fine:
https://github.com/ManageIQ/manageiq/commit/c57f61036234db623fa7668095a3393121c104fb

commit c57f61036234db623fa7668095a3393121c104fb
Author:     Martin Povolny <mpovolny>
AuthorDate: Tue Dec 5 15:07:56 2017 +0100
Commit:     Satoe Imaishi <simaishi>
CommitDate: Fri Dec 8 12:07:26 2017 -0500

    Merge pull request #16490 from skateman/websocket-webmks
    
    Allow proxying WebMKS consoles using the WebsocketWorker
    (cherry picked from commit 6421e3ddf8512dc106119347e1dd36729de28f95)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1523404

 lib/websocket_proxy.rb           | 32 +++++++++++++-------------------
 lib/websocket_right.rb           | 14 ++++++++++++++
 lib/websocket_socket.rb          |  9 +++++++++
 lib/websocket_ssl_socket.rb      | 22 ++++++++++++++++++++++
 lib/websocket_webmks.rb          | 30 ++++++++++++++++++++++++++++++
 spec/lib/websocket_proxy_spec.rb | 16 ++++++++--------
 6 files changed, 96 insertions(+), 27 deletions(-)
 create mode 100644 lib/websocket_right.rb
 create mode 100644 lib/websocket_socket.rb
 create mode 100644 lib/websocket_ssl_socket.rb
 create mode 100644 lib/websocket_webmks.rb

Comment 3 CFME Bot 2017-12-08 17:19:10 UTC
New commit detected on ManageIQ/manageiq-ui-classic/fine:
https://github.com/ManageIQ/manageiq-ui-classic/commit/383ed49e5ac289637457d7a573eb8a4048649d04

commit 383ed49e5ac289637457d7a573eb8a4048649d04
Author:     Milan Zázrivec <mzazrivec>
AuthorDate: Tue Dec 5 10:06:15 2017 +0100
Commit:     Satoe Imaishi <simaishi>
CommitDate: Fri Dec 8 12:08:23 2017 -0500

    Merge pull request #2768 from skateman/webmks-proxied
    
    Adjust the remote console views/controllers for WebMKS proxying
    (cherry picked from commit a8407ddad996a4cec631c1fd89ced8bce5e7b285)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1523404

 app/controllers/vm_remote.rb                 | 15 +++++++--------
 app/views/vm_common/console_webmks.html.haml | 11 ++++++++++-
 2 files changed, 17 insertions(+), 9 deletions(-)

Comment 4 CFME Bot 2017-12-08 17:19:45 UTC
New commit detected on ManageIQ/manageiq-providers-vmware/fine:
https://github.com/ManageIQ/manageiq-providers-vmware/commit/79b7517f7035b17d615f6bb5f70afde7c573521f

commit 79b7517f7035b17d615f6bb5f70afde7c573521f
Author:     Adam Grare <agrare>
AuthorDate: Tue Dec 5 09:05:30 2017 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Fri Dec 8 12:08:02 2017 -0500

    Merge pull request #140 from skateman/webmks-proxy
    
    Proxy WebMKS connections through the WebSocket worker
    (cherry picked from commit 6deabdd6ee6e99159cd0638fcd0ca3d6fb118849)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1523404

 .../providers/vmware/infra_manager/vm/remote_console.rb | 17 +++++++++++++++--
 .../vmware/infra_manager/vm/remote_console_spec.rb      |  4 ++--
 2 files changed, 17 insertions(+), 4 deletions(-)

Comment 5 Kedar Kulkarni 2017-12-15 18:24:38 UTC
Verified in 5.8.3.0
New WebMSK Console needs WebSocket role enabled to connect to console.

Comment 18 errata-xmlrpc 2018-02-28 13:11:00 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:0374

Comment 20 Red Hat Bugzilla 2023-09-15 01:26:37 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 365 days