Bug 1523875

Summary: FTBFS with Annobin
Product: [Fedora] Fedora Reporter: Michal Schorm <mschorm>
Component: annobinAssignee: Nick Clifton <nickc>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: urgent Docs Contact:
Priority: high    
Version: rawhideCC: dciabrin, fweimer, hhorak, jkurik, jstanek, mbayer, mkocka, mmuzila, mschorm, nickc, praiskup, zbyszek
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: annobin-2.5.1-5.fc28 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-12-11 12:04:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1502660    
Attachments:
Description Flags
Minimal reproducer - Patch of mariadb.spec on top of add7d9cf1ac commit none

Description Michal Schorm 2017-12-08 23:26:33 UTC
Created attachment 1365066 [details]
Minimal reproducer - Patch of mariadb.spec on top of add7d9cf1ac commit

When used "-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1" compiler option, MariaDB FTBFS.

Event                            | Plugins
PLUGIN_FINISH_UNIT               | Generate final annotations
PLUGIN_START_UNIT                | Generate global annotations
PLUGIN_ALL_PASSES_END            | Generate per-function annotations
lto1: internal compiler error: Segmentation fault

---

This issue apperas only in part of TokuDB storage engine, which is only available on x86_64 arch.

I was able to prepeare minimal reproducer SPECfile (note, that normally, MariaDB can take hours to compile and hours to run self tests, so this one onli takes tow or three minutes).
I basically call Cmake to prepare and test everything, then 'cd' to the directory where the issue appears and make only that directory (~30 files?)

The reproducer is meand as patch of 'mariadb' SPECfile on top of add7d9cf1ac64708c2111c2b8fe068c656f9b56b commit.

Note the "exit 5" command at the end of the patch, that kills the build anyway, if it won't end on internal compiler error.

When following line un-commented, the issue won't appear. 
#CFLAGS=`echo $CFLAGS| sed -e "s|-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1||g" `

---

Well, this one took me several days to trace. I was not amused ... :D

Comment 2 Jan Kurik 2017-12-11 08:13:36 UTC
@Michael: I am not sure why I am on needinfo? Is there any information you need from me ?

Comment 3 Michal Schorm 2017-12-11 09:42:32 UTC
@Jan: Sorry, I meant Florian.
I looked at the #1502660 bug picking Reporter instead of Asignee, my bad.

Comment 4 Nick Clifton 2017-12-11 10:47:34 UTC
    Hi Michal,

      I am sorry that the plugin has caused you so much grief.

      The problem is the LTO process which can run the compiler without an output
      file attached.  The annobin plugin was not expecting this, and just assumed
      that the file was there.

      I have checked in a patch to the annobin plugin which fixes this behaviour,
      so please try re-enabling the redhat-annobin-cc1 spec file and see if
      compilation now works for you.

    Cheers
      Nick

Comment 5 Michal Schorm 2017-12-11 12:04:01 UTC
Hi, thanks

Compilation sucessful:
https://koji.fedoraproject.org/koji/getfile?taskID=23641086&volume=DEFAULT&name=build.log

I pushed the removal of the workaround to the Rawhide and bumped release as commit 1b8fb85b0fa3aed4703b0012f798cd52cfdc693b.

I'm not gonna rebuild MariaDB yet, from what I understood, Annobin isn't critical or highly important for the package.
However, it will be present in any later releases.

I'm glad it was resolved that fast :)

Comment 6 Zbigniew Jędrzejewski-Szmek 2017-12-12 08:10:05 UTC
*** Bug 1524737 has been marked as a duplicate of this bug. ***