Bug 1524245
| Summary: | Review Request: go-hvkvp - Utility to read keyvalue pairs from the Hyper-V Data Exechange service | |||
|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Gerard Braad <me> | |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> | |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | rawhide | CC: | package-review, sgirijan, zebob.m | |
| Target Milestone: | --- | |||
| Target Release: | --- | |||
| Hardware: | All | |||
| OS: | Linux | |||
| Whiteboard: | ||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | ||
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1527820 (view as bug list) | Environment: | ||
| Last Closed: | 2020-08-10 00:57:29 UTC | Type: | --- | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 201449, 1527820 | |||
|
Description
Gerard Braad
2017-12-11 03:42:19 UTC
Hello,
- Not useful:
%if ! 0%{?with_bundled}
export GOPATH=$(pwd):%{gopath}
%else
echo "Unable to build from bundled deps. No Godeps nor vendor directory"
exit 1
%endif
- Remove unused stuff:
# Build with debug info rpm
%global with_debug 1
# Run tests in check section
%global with_check 1
- What are you trying to do here? You make a directory just to remove it on the next line:
%build
mkdir -p src/%{import_path}
rmdir src/%{import_path}
ln -s ../../../ src/%{import_path
It should look like this:
mkdir -p ./_build/src/%{provider}.%{provider_tld}/%{project}
ln -s $(pwd) ./_build/src/%{provider_prefix}
export GOPATH=$(pwd)/_build:%{gopath}
%gobuild -o bin/%{executable_name} %{import_path}/cmd/%{executable_name}
- Not needed even for EL6/7:
# handle license on el{6,7}: global must be defined after the License field above
%{!?_licensedir: %global license %doc}
- Changelog info is not coherent with the header. It should just be:
* Mon Dec 11 2017 Gerard Braad <me> 0.4-0.2
- Use a more meaningful name for your archive, with:
Source0: https://%{provider_prefix}/archive/%{version}/%{name}-%{version}.tar.gz
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience. This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. |