Bug 1524457

Summary:	check for same hostnames(bricks from same host/node) while adding bricks in erasure (ec) ie disperse volumes and error out accordingly(use force to over-ride)
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	Nag Pavan Chilakam <nchilaka>
Component:	disperse	Assignee:	Sheetal Pamecha <spamecha>
Status:	CLOSED ERRATA	QA Contact:	Pranav Prakash <prprakas>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rhgs-3.4	CC:	pprakash, prprakas, puebele, rhs-bugs, rkothiya, sheggodu, storage-qa-internal, ubansal
Target Milestone:	---	Keywords:	ZStream
Target Release:	RHGS 3.5.z Batch Update 3
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-6.0-38	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:
Clones:	1774379 (view as bug list)		Environment:
Last Closed:	2020-12-17 04:50:16 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1774379

Description Nag Pavan Chilakam 2017-12-11 14:51:01 UTC

Description of problem:
=====================
the ideal way of configuring ec volumes is to have all bricks in different nodes(no 2 bricks of same dht-subvol must be on same node)
that is why when we create an ec volume and we use same hostname for 2 bricks of same dht-subvol, it fails saying it is not optimal
user must use force to over-ride this behavior, which is perfect.

However the same check is not made when we do an add-brick


Version-Release number of selected component (if applicable):
==================
3.12.2-1

How reproducible:
====
always

Steps to Reproduce:
1.create a 4+2 ec vol on 6 node setup
2. now add a new subvol of 6 bricks such that 2 bricks are hosted by n1 , 2 by n2 and 2 by n3


Actual results:
add brick passes without any warns/errors

Expected results:
=========
must fail and throw a error saying this is not optimal setup and user must use force

Comment 5 Sheetal Pamecha 2020-01-02 06:50:11 UTC

REVIEW: https://review.gluster.org/23729 (glusterd: check for same node while adding bricks in disperse volume) posted (#4) for review on master by Sheetal Pamecha

Comment 12 errata-xmlrpc 2020-12-17 04:50:16 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (glusterfs bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:5603