Bug 1525313

Summary: Search bar is unreliable
Product: [Fedora] Fedora Reporter: David Gibson <dgibson>
Component: atrilAssignee: Wolfgang Ulbrich <raveit65.sun>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 27CC: alt-gtk-de-sig, dgibson, raveit65.sun
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: atril-1.19.6-1.fc27 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-02-06 11:20:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description David Gibson 2017-12-13 02:59:07 UTC
Description of problem:

Searching documents is weirdly unreliable as of quite recently.  There are several symptoms:
    * Sometimes it reports "0 found on this page" even with one highlighted on this page
    * Often "Find Next"/"Find Previous" don't find anything even though there are known other matches in the documents
    * Sometimes rapidly, repeatedly clicking the next/prev buttons will cause it to find matches it didn't with a single click.

Version-Release number of selected component (if applicable):

atril-1.19.5-1.fc27.x86_64

This problem has appeared quite recently, but I don't know exactly what package version it started at.

How reproducible:

At least on certain documents seems to happen most of the time.

Steps to Reproduce:
1. Open large PDF document with some know search terms
2. Press Ctrl-F
3. Type a string know to appear repeatedly in the document
4. Press "Find Next" to step through occurrences of the string

Actual results:

Generally finds a first match correctly.

May print "0 found on this page" even with a match highlighted.

Find Next/Find Previous may not find additional matches even when they exist.

Expected results:

Find Next/Find Previous reliably step through matches in the document.

Additional info:

Find Previous seems to be slightly more reliable than Find Next, but it's hard to be sure.

Comment 1 David Gibson 2017-12-19 06:01:33 UTC
An example document which demonstrates this problem can be downloaded from:

https://openpowerfoundation.org/?resource_lib=ibm-power-isa-version-2-07-b

Search, for example, for "hfscr" in this document and the weird behaviour described above shows up.

Comment 2 Wolfgang Ulbrich 2017-12-19 08:28:40 UTC
Was this a problem with atril-1.18.1 from f26/f25 ?

Comment 3 Wolfgang Ulbrich 2017-12-19 09:13:36 UTC
Confirmed, but it seems that the problem occurs only in continuous mode.
Also, it doesn't matter if single or double page is chosen.
Do we have a cache problem?
Tested with your PowerISA_V2.07B.pdf document.
Good that it isn't a problem with the new feature caret-navigation.

Comment 4 David Gibson 2017-12-20 02:44:32 UTC
I'm pretty sure it wasn't a problem in f26 or f25 - I certainly didn't notice it until recently.  I didn't notice it until after the fix for bug 1513826 went in.

Thanks for pointing out it only reproduces in continuous mode, I hadn't noticed that.  That gives me a workaround which will make life much less painful.

Comment 5 Wolfgang Ulbrich 2018-01-02 15:36:44 UTC
Can you please test https://koji.fedoraproject.org/koji/taskinfo?taskID=23972942
This fixes the regression for me.
Hope i don't introduce another one.

Comment 6 David Gibson 2018-01-02 23:20:27 UTC
Looks good to me, thanks!

Comment 7 Fedora Update System 2018-01-05 15:34:00 UTC
atril-1.19.6-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-78aefc9e33

Comment 8 Fedora Update System 2018-01-06 21:09:44 UTC
atril-1.19.6-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-78aefc9e33

Comment 9 Fedora Update System 2018-02-06 11:20:28 UTC
atril-1.19.6-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2018-02-06 15:26:38 UTC
atril-1.19.6-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.